From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e])
	by sourceware.org (Postfix) with ESMTPS id EA4723858CDB
	for <gcc-patches@gcc.gnu.org>; Wed,  2 Nov 2022 08:18:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA4723858CDB
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ed1-x52e.google.com with SMTP id l11so24045233edb.4
        for <gcc-patches@gcc.gnu.org>; Wed, 02 Nov 2022 01:18:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=qUN6ZZLSz/votV6yZEAQNs8ldvjvx57nKDf+591u7XU=;
        b=Q1sL5tTx9nJ2emek8yUSEttgQul1RwaGLaVgO+ds1j0Vg8qdvScyg7mf+etSoDQLmP
         sydgKSbdqEZBt+nVtpbTNlmZlNI6fSNXhAu2lIcfhs+Rxj6oreLZCXTv0aAQ1XxkxKRs
         FVhLqe+28SH3g7YNnHZWWaVPqHhXp6U1Wm0hNvmrC4Mcm0VvBFNPCRfEgUMXajO8Qe1i
         aBr11jZqYAeax4TLdyX15v1xy9J9mX9OiFy+XFPa8szWFPGLmxCURuHZAeNlGD02n0hi
         LlL6Z3zpelwXxlZikbqAj1XitDqZ6X+tPpLvQjuqPMUzl6ALI9grsCTm9Fn18MzH8Fq5
         tOjw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=qUN6ZZLSz/votV6yZEAQNs8ldvjvx57nKDf+591u7XU=;
        b=uAsT8Sn0hG4jhdEe+2NiP/Z03ijTs4Um1Acigw/8xyGaCLqYgs6HQx/gYsls7aJUId
         hZ28HRSEpT7kt+DEPcpr/BnQDnMe9fI7BG1MAWmdz9tA/hQ7aZMK0yV3hoevJrPii4Gg
         P7m4e0OmiB+tycknRdR8PrP9GxQ2gZrkVRTeeLQjlLpksZ271HGnT1OEF9ZGCtW5dUit
         iNub/Z3YhGQsUnKg6CATSIFrKYcGDF1G9KnRQ1VGHjD7ChHSg01w+JYPpeSLSZ3FIWRj
         zrs9e0Xpifr4Wp+coxMW1hrzQbcstm0KDT1WaCJRPfspeBfpqmWyFV2fLjTWG+PCGaou
         3OLw==
X-Gm-Message-State: ACrzQf3YU1kqBIOc+pyJmCI0Ne9wtiUZ4EBjzTpfpn/EnlwcFDlaegcE
	DbaWQFd4PYDKYYWMq8beTG7xd3VIyaNM9XTLr8A=
X-Google-Smtp-Source: AMsMyM5QE5wh3GFfA71h6BpwVhOpYmXDjbb2HB1KJmYtsQsaxfZm7UtEy5AId2Dk7yDqQYd1627xwdQ+WrUfW0xipY4=
X-Received: by 2002:a50:871a:0:b0:461:52a9:1da6 with SMTP id
 i26-20020a50871a000000b0046152a91da6mr23090969edb.94.1667377108178; Wed, 02
 Nov 2022 01:18:28 -0700 (PDT)
MIME-Version: 1.0
References: <052c0ba5-79fc-ad55-bfa9-38b5b3394e11@redhat.com>
In-Reply-To: <052c0ba5-79fc-ad55-bfa9-38b5b3394e11@redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Wed, 2 Nov 2022 09:18:16 +0100
Message-ID: <CAFiYyc0KPF01iVKM1J2=+ZGb0s0H+HvveH4yRNv-L+TRcqS7tw@mail.gmail.com>
Subject: Re: [COMMITTED] Allow ranger queries on exit block.
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Nov 1, 2022 at 2:20 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Ranger was not allowing the exit block to be queried for range_on_entry
> or exit, for no good reason.  This removes that restriction.
>
> Interestingly, it seems that when we calculate dominance info, GCC does
> not set the dominators for the EXIT_BLOCK?  I worked around it by
> starting with a single pred of the exit block for my queries, but as a
> result it doesn't support multiple exit blocks.
>
> For the record:
>
>    get_immediate_dominator (CDI_DOMINATORS, EXIT_BLOCK_PTR_FOR_FN (cfun))
>
> returns NULL.   Is this actually working as intended?  It was unexpected
> on my part.

Yes, working as "intended".  EXIT and ENTRY
basic-blocks are artificial so having dominance info for them would be
somewhat odd.

Richard.

>
> Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed.
>
> Andrew