From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16628 invoked by alias); 29 Aug 2017 11:42:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16615 invoked by uid 89); 29 Aug 2017 11:42:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:switch, sk:switch-, lesson, friends X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Aug 2017 11:42:48 +0000 Received: by mail-wm0-f44.google.com with SMTP id f13so19400662wme.1 for ; Tue, 29 Aug 2017 04:42:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qGUOngql1VZJNZQ3MWYCtE8MslKemRdvBzAib1Xh7eE=; b=ubAdnKEHz7otO2EX26Q7h9VHGYEVYWV04O/MsRVcjEm2iBKUZ4IAERx9z67f2DkpTd QyoXx/fPUJsuLz5QVutkNnCSQQs00kh6E4ZtOmvJzrwC4q48zH3lH/qtZmpiYoIU28n3 Z6R/+xfTlOyyRxLND9iA0rr61m/SP2oic4IN+PN7FW/xNXH44riYUcSLhW1Tn7YY5Hs1 DaQ3zKs55pdADyrMuYqqKxYUpkN8tdLkCAfOQzML0oE2Cui5EqbTqwvnitlpKrNVa888 sDR/Ik3hYyPp9ZeZqcJBrRTLqrLKXgPutJuhMvmANa2MbyhvYcuK4lbp+UgoI5AzycaA jKWA== X-Gm-Message-State: AHYfb5iaHbUFcbtGP+Qea3CrXAmupXhky9zwzRkK80ADy0Ty+fxGeZY7 qfm8nTjulI09hTTUQkc+QaKzkPskIVnd X-Received: by 10.80.240.10 with SMTP id r10mr3489404edl.148.1504006966685; Tue, 29 Aug 2017 04:42:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.180.249 with HTTP; Tue, 29 Aug 2017 04:42:46 -0700 (PDT) In-Reply-To: References: <8caac5fa-2f65-2dcf-3444-d48a7ca3d306@suse.cz> <615dfc0a-aded-22e5-333e-f613eb577c7c@suse.cz> From: Richard Biener Date: Tue, 29 Aug 2017 12:58:00 -0000 Message-ID: Subject: Re: [PATCH][RFC] Make expansion of balanced binary trees of switches on tree level. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches , Jan Hubicka , Martin Jambor Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg01642.txt.bz2 On Thu, Aug 24, 2017 at 5:35 PM, Martin Li=C5=A1ka wrote: > On 08/18/2017 12:25 PM, Martin Li=C5=A1ka wrote: >> On 08/18/2017 11:30 AM, Richard Biener wrote: >>> On Tue, Aug 15, 2017 at 2:37 PM, Martin Li=C5=A1ka wro= te: >>>> On 08/14/2017 10:32 AM, Richard Biener wrote: >>>>> Hmm, but the existing "lowering" part is called from the >>>>> switch-conversion pass. So >>>>> I'm not sure a new file is good. >>>> >>>> Good, I'm not against having that in a single file. So new version of = the patch >>>> does that. >>>> >>>> Patch can bootstrap on ppc64le-redhat-linux and survives regression te= sts. >>>> >>>> Ready to be installed? >>> >>> Hmm, I see you duplicate add_case_node for example. Is that just tempo= rary? >>> If not can you please factor out the data structure and common code? >>> (case.[Ch]?) >> >> You are right. As we'll generate just jump table in stmt.c the proper fi= x is to remove >> all usages of 'case_node' in the file because simple iteration of labels= will work fine. >> Let me do it incrementally to minimize fall out :) > > Hello. > > So lesson learned. I should follow your recommendation and make the clean= -up in stmt.c. I didn't > so adding new variant of case_node with a different size caused bootstrap= failure on aarch64 and > it was quite hard to debug. So sending updated version of the patch which= has cleaned up stmt.c. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests= . Same of aarch64-linux-gnu. > > Ready to be installed? No ChangeLog entry for tree-switch-conversion.c? At least you added make_pass_lower_switch and friends. Ok with a little more verbose changelog. Thanks and sorry for the delay, Richard. > Martin >> >> Martin >> >>> >>> Thanks, >>> Richard. >>> >>>> Martin >> >