From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101034 invoked by alias); 21 Aug 2015 08:35:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 101022 invoked by uid 89); 21 Aug 2015 08:35:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_40,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f180.google.com Received: from mail-ig0-f180.google.com (HELO mail-ig0-f180.google.com) (209.85.213.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 21 Aug 2015 08:35:07 +0000 Received: by igfj19 with SMTP id j19so9378749igf.1 for ; Fri, 21 Aug 2015 01:35:05 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.50.62.112 with SMTP id x16mr1543765igr.23.1440146105383; Fri, 21 Aug 2015 01:35:05 -0700 (PDT) Received: by 10.107.32.140 with HTTP; Fri, 21 Aug 2015 01:35:05 -0700 (PDT) In-Reply-To: References: <20150723203112.GB27818@gate.crashing.org> <20150810082355.GA31149@arm.com> <55C8BFC3.3030603@redhat.com> Date: Fri, 21 Aug 2015 08:37:00 -0000 Message-ID: Subject: Re: [PR64164] drop copyrename, integrate into expand From: Richard Biener To: Alexandre Oliva Cc: Andreas Schwab , Christophe Lyon , GCC Patches , Patrick Marlier , Jeff Law , James Greenhalgh , "H.J. Lu" , Segher Boessenkool , David Edelsohn , Eric Botcazou Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01281.txt.bz2 On Fri, Aug 21, 2015 at 9:57 AM, Alexandre Oliva wrote: > On Aug 19, 2015, Alexandre Oliva wrote: > >> I have verified in the expand dumps that both the gimple and the rtl >> representation in the relevant parts of the code are identical, except >> for the presence of debug stmts and insns. > > While comparing the dumps, I noticed -fdump-unnumbered-links no longer > worked like it did back when I introduced it, with the very purpose of > making it easier to compare dumps with and without debug insns. > > When the insn_uid was moved out of the u[] array, the indices that > print-rtl tested to tell whether to omit the ids of the prev and next > insns got off by one. > > This patch updates the test to match the current indices. > > Bootstrapping on ia64-linux-gnu. Ok to install? Ok. Thanks, Richard. > fix -fdump-unnumbered-links > > From: Alexandre Oliva > > for gcc/ChangeLog > > * print-rtl.c (print_rtx): Check the correct range for > flag_dump_unnumbered_links to behave as documented. > --- > gcc/print-rtl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/print-rtl.c b/gcc/print-rtl.c > index aacadbb..b541d83 100644 > --- a/gcc/print-rtl.c > +++ b/gcc/print-rtl.c > @@ -550,7 +550,7 @@ print_rtx (const_rtx in_rtx) > } > > if (flag_dump_unnumbered > - || (flag_dump_unnumbered_links && (i == 1 || i == 2) > + || (flag_dump_unnumbered_links && i <= 1 > && (INSN_P (in_rtx) || NOTE_P (in_rtx) > || LABEL_P (in_rtx) || BARRIER_P (in_rtx)))) > fputs (" #", outfile); > > > -- > Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/ > You must be the change you wish to see in the world. -- Gandhi > Be Free! -- http://FSFLA.org/ FSF Latin America board member > Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer