From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27898 invoked by alias); 25 Mar 2013 09:15:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27875 invoked by uid 89); 25 Mar 2013 09:15:42 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_VX autolearn=ham version=3.3.1 Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 09:15:39 +0000 Received: by mail-wi0-f175.google.com with SMTP id c10so4485499wiw.2 for ; Mon, 25 Mar 2013 02:15:37 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.93.68 with SMTP id cs4mr16465107wjb.17.1364202937052; Mon, 25 Mar 2013 02:15:37 -0700 (PDT) Received: by 10.194.56.100 with HTTP; Mon, 25 Mar 2013 02:15:36 -0700 (PDT) In-Reply-To: References: <5097FE1B.6060409@verizon.net> <50A30E90.7080704@verizon.net> <50B3B47F.9010905@verizon.net> <50C0B657.2000004@verizon.net> <50E8FB30.2010202@verizon.net> <50F89FF1.9080107@verizon.net> <9B9BDD08-8F90-4073-93D4-659D1FABCDA0@comcast.net> <50F9AE31.9040109@verizon.net> <7AC2CAB1-8248-4AF5-B49F-9764512E13B6@gmail.com> <511C033D.9010001@verizon.net> <293273AE-7B20-4708-8B91-10BCDA813B17@gmail.com> <5147CFA4.4010909@verizon.net> <34C52E41-8F68-4398-9D0D-DC1350E810FF@kugelworks.com> <51485B7B.10901@verizon.net> Date: Mon, 25 Mar 2013 09:15:00 -0000 Message-ID: Subject: Re: [PING^5] PR 54805: __gthread_tsd* in vxlib-tls.c From: Richard Biener To: Maxim Kuvyrkov Cc: rbmj , GCC Patches , Mike Stump Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-03/txt/msg00973.txt.bz2 On Thu, Mar 21, 2013 at 12:22 AM, Maxim Kuvyrkov wro= te: > On 20/03/2013, at 1:35 AM, rbmj wrote: > >> On 19-Mar-13 03:04, Maxim Kuvyrkov wrote: >>> >>> Will commit to trunk once the server is up. > > The patch is now committed. > >>> >>> Regarding 4.8, we should've really tried to work it out earlier. If yo= u want to pursue backport to 4.8, please attach the log of PPA system rejec= ting the package >> >> The error is: >> >> =3D=3D=3D=3D=3D=3D >> Finished at 20130318-0642 >> Build needed 00:14:20, 804796k disk space >> Function `__gthread_get_tsd_data' implicitly converted to pointer at /bu= ild/buildd/gcc-powerpc-wrs-vxworks-4.8.0+0svn196132/libgcc/config/vxlib-tls= .c:164 >> >> >> >> Our automated build log filter detected the problem(s) above that will >> likely cause your package to segfault on architectures where the size of >> a pointer is greater than the size of an integer, such as ia64 and amd64. >> >> This is often due to a missing function prototype definition. >> >> Since use of implicitly converted pointers is always fatal to the applic= ation >> on ia64, they are errors. Please correct them for your next upload. >> =3D=3D=3D=3D=3D=3D >> >> This problem does not apply on the target (powerpc-wrs-vxworks), where s= izeof(int*) =3D=3D sizeof(int(*)()) =3D=3D sizeof(int) =3D=3D 4. However, = the build system's filters are too stupid to realize this. Because the war= ning is spurious really the fact that the automated build system rejects th= e package is a bug on the build system's part. However, doing it the Right= Way is so _easy_... > > Richard, > > As release manager, do you have any objections to backporting this patch = to 4.8 branch? It affects only VxWorks targets and it is quite harmless (t= he patch fixes a compilation warning during building GCC for VxWorks target= s). It's certainly fine now. Richard. > Thanks, > > -- > Maxim Kuvyrkov > KugelWorks >