From: Richard Biener <richard.guenther@gmail.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Remove conditional STATIC_ASSERT.
Date: Thu, 5 May 2022 15:08:05 +0200 [thread overview]
Message-ID: <CAFiYyc0LByk2VOMqYYv156XnYtY2TJb8wCF3_fsWCqE+BhVzbw@mail.gmail.com> (raw)
In-Reply-To: <6a3b7979-46ff-cc47-fd46-f0f799bad39c@suse.cz>
On Thu, May 5, 2022 at 2:41 PM Martin Liška <mliska@suse.cz> wrote:
>
> On 5/5/22 14:29, Richard Biener wrote:
> > Can we then use static_assert (...) instead and remove the
> > macro?
>
> Oh yes, we can ;)
>
> > Do we have C compiled code left (I think we might,
> > otherwise we'd not have __cplusplus guards in system.h),
> > in which case the #if should change to #ifdef __cplusplus?
>
> No, there's no such a consumer of the macro.
OK, but for C uses it should still be different so my suggestion
to change to #ifdef __cplusplus remains. OTOH then the change
is somewhat pointless.
> What about the updated version of the patch?
>
> Cheers,
> Martin
next prev parent reply other threads:[~2022-05-05 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 12:18 Martin Liška
2022-05-05 12:29 ` Richard Biener
2022-05-05 12:41 ` Martin Liška
2022-05-05 12:51 ` Pedro Alves
2022-05-05 12:56 ` Martin Liška
2022-05-05 13:08 ` Richard Biener [this message]
2022-05-09 8:45 ` Martin Liška
2022-05-09 12:05 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc0LByk2VOMqYYv156XnYtY2TJb8wCF3_fsWCqE+BhVzbw@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).