From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 969343858C2B for ; Thu, 20 Jul 2023 07:16:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 969343858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b8390003e2so5863951fa.0 for ; Thu, 20 Jul 2023 00:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689837387; x=1690442187; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OpnQ351Y9ETvCuEOuBWUsKN/K38C0K0x5tZB2GA9EUY=; b=OOq2kWs33mag9LQoS47wDI66l+ehNB5PE5GiU87pkmOKiRNJflCjVHhPQY+qaMvuux ZGhoEX/11n7Fsdm3ZkDi9Mf0RCUrpMtdbt8xZanbCFF2edYgNb4ec1lKTOGwNisjDXTh uibN4UPUftkbQpuz9weWu/ykr2tW29S4TqRtd5BWhC5XnW/lyba+3+a2J3ywzL8dAXMz agwS+akibh45dlkct+e8sZjKWQL8mSMyunE+X3gD/wwBykbJT4Vium+rzphNieJvfYuV hYahZMmR1Z0DtZrPtbHczgaYfEM7q6Md3oCDvmVyBQTjNtek9/GuGMoHWjjg3Q9c2/bt 7t4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689837387; x=1690442187; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OpnQ351Y9ETvCuEOuBWUsKN/K38C0K0x5tZB2GA9EUY=; b=c3I7aScYuRYrkNW/VfGoOcfSWB5LJBBajNHnn7gZK+DBOwqN8Kn1XjqSQPaOBUSJJ7 WKHQUOL52JmOsPRDTgS+Xlt0YWw063uRD/ufngQhHUCVY2lS8IxGCWPg0+UCGFYQ1Qj3 /1L1N/cr0+Ec7Bj0JR408Z3NTD9ICPeLhTZiqIrkOinyb3t2sOvqRwUwQKZ7Z9BibVHt b/gDmOv0Q5uR6PsYbKB5kgDh28se9Vt7YZySZbWu+2iaAgCuWjyW50Oc+Arde5M1QXGs IfY2mQ4GBFkXd91m9PjWdMFT/NVDkLr+GLQNI+Xa48RPAdPlWG0GE/yfjYNpNn/X9hZi NzNg== X-Gm-Message-State: ABy/qLZmn60MM9mDvOnDTwwqvPq2f1xOOD6PUCkGhb8zNaIdHTMjl34g Z4XpqxovM7COB4EsfdygBwLTyEan/IYxRnSvQAE= X-Google-Smtp-Source: APBJJlFApDRKZfeaUwIXTNWRH8C3cNunF8XcT0klLAV0zIYHEdMMS0z0rwUQD+0+Pt5GMkW5UXF9YccYAFQAZ6BkVfM= X-Received: by 2002:a2e:b17b:0:b0:2b6:cbba:1307 with SMTP id a27-20020a2eb17b000000b002b6cbba1307mr1497334ljm.0.1689837386865; Thu, 20 Jul 2023 00:16:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 20 Jul 2023 09:15:52 +0200 Message-ID: Subject: Re: [PATCH 2/3] testsuite: Require 128-bit vectors for bb-slp-pr95839.c To: "Maciej W. Rozycki" Cc: YunQiang Su , Rainer Orth , Mike Stump , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 19, 2023 at 4:34=E2=80=AFPM Maciej W. Rozycki wrote: > > On Wed, 12 Jul 2023, Richard Biener wrote: > > > > > That said, we should handle this better so can you file an > > > > enhancement bugreport for this? > > > > > > Filed as PR -optimization/110630. > > > > Thanks! > > Thanks for making this improvement. I've checked MIPS results and code > produced now is as follows: > > daddiu $sp,$sp,-64 > sd $5,24($sp) > sd $7,40($sp) > ldc1 $f0,24($sp) > ldc1 $f1,40($sp) > sd $4,16($sp) > sd $6,32($sp) > ldc1 $f2,32($sp) > add.ps $f1,$f0,$f1 > ldc1 $f0,16($sp) > add.ps $f0,$f0,$f2 > sdc1 $f1,56($sp) > ld $3,56($sp) > sdc1 $f0,48($sp) > ld $2,48($sp) > jr $31 > daddiu $sp,$sp,64 > > which does do vector stuff now, although it's still considerably worse > than my handwritten example: > > > > dmtc1 $4,$f0 > > > dmtc1 $5,$f1 > > > dmtc1 $6,$f2 > > > dmtc1 $7,$f3 > > > add.ps $f0,$f0,$f1 > > > add.ps $f2,$f2,$f3 > > > dmfc1 $2,$f0 > > > jr $31 > > > dmfc1 $3,$f2 > > Or I'd say it's pretty terrible, but given the current situation with the > MIPS backend I'm going to leave it to the new maintainer to sort out. Yeah, I also wondered what is wrong ... I suspect it's the usual issue of parameter passing causing spilling ... > > > Do you agree it still makes sense to include bb-slp-pr95839-v8.c wit= h the > > > testsuite? > > > > Sure, more coverage is always nice. > > Thanks, committed (with the `vect64' requirement removed, as we can take > it for granted with `vect_float'). > > Maciej