public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Bin Cheng <Bin.Cheng@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PATCH TEST]Rectify test case gcc.dg/tree-ssa/ivopt_mult_4.c
Date: Fri, 26 May 2017 11:50:00 -0000	[thread overview]
Message-ID: <CAFiYyc0LjHDt+W1nH4E6AVjnyQHmxgUFWcKpJLpM6Te0PZWDeQ@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0802MB2176BDEBA40D883F11CF43B4E7FF0@VI1PR0802MB2176.eurprd08.prod.outlook.com>

On Thu, May 25, 2017 at 8:00 PM, Bin Cheng <Bin.Cheng@arm.com> wrote:
> Hi,
> I believe this tests has been wrongly modified previously.  It is to test that the exit check on
> pointer shouldn't be replaced by integer IV.  Somehow GCC starts replacing the check on
> integer IV with pointer IV.  It's valid, though inefficient.  And somehow we starting checking
> this iv replacement.   This patch rectifies it by specifically checking the check on pointer
> shouldn't be replaced.

So maybe it should then test that the pointer test prevails?  Or
rather that it doesn't replace
any exit test?  If 'p' changes for '_2' for unrelated reasons the
pattern will be not testing what
it is supposed to test...

Richard.

> Bootstrap and test in series on x86_64.  Is it OK?
> Thanks,
> bin
> gcc/testsuite/ChangeLog
> 2017-05-11  Bin Cheng  <bin.cheng@arm.com>
>
>         * gcc.dg/tree-ssa/ivopt_mult_4.c: Explicitly check comparison
>         on pointer should not be replaced.

  reply	other threads:[~2017-05-26 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 18:15 Bin Cheng
2017-05-26 11:50 ` Richard Biener [this message]
2017-05-31 12:45   ` Bin.Cheng
2017-05-31 13:34     ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc0LjHDt+W1nH4E6AVjnyQHmxgUFWcKpJLpM6Te0PZWDeQ@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=Bin.Cheng@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).