From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130768 invoked by alias); 26 May 2017 11:49:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 130744 invoked by uid 89); 26 May 2017 11:49:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-oi0-f46.google.com Received: from mail-oi0-f46.google.com (HELO mail-oi0-f46.google.com) (209.85.218.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 11:49:44 +0000 Received: by mail-oi0-f46.google.com with SMTP id b204so9582425oii.1 for ; Fri, 26 May 2017 04:49:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lUw8X3j71+7zuOZ7HcJcP/ojFZBEBFSAPsRuujaZ6lE=; b=q+4344RG86BTM0PpAEzSDvtsvG+dD/WyioOY0YwjI2vhBRn5ekbI4xliDLLe9T4+Yq A0XtjP2CwOEeAJ5S82uDHGYXEx5Egip7hlzqOhESs4dHl71/YuihJkWHUhBCtv7K5O+m 33aMeP9B1BZMkAxnURK8tadx4KIFez50JBTT8+0hnLQHb28cmQ9CShutaf7Qpbwdpjd4 0AhhdVr6PvycStlrU3ZbnfaK87I+Q/4pRk2oMiPyAc7l6nbZToa77v6ZfIwX/w4QyKGx nsLQaquWg4j5DP2ADlLi8cVbI25Idjd2a4cBzlB+K6V8S9fkVuYVR4CEsAnfdSkWAmUy 3cBw== X-Gm-Message-State: AODbwcBmgMa1qgY5w8lyGPKUMvjp7qDXBzBWs8/DTJ4NM7BDFRybg953 e6/cMNiyVTNcwwVImOanYV4QvQkcwjMk X-Received: by 10.202.181.68 with SMTP id e65mr600245oif.212.1495799386399; Fri, 26 May 2017 04:49:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.51.83 with HTTP; Fri, 26 May 2017 04:49:46 -0700 (PDT) In-Reply-To: References: From: Richard Biener Date: Fri, 26 May 2017 11:50:00 -0000 Message-ID: Subject: Re: [PATCH TEST]Rectify test case gcc.dg/tree-ssa/ivopt_mult_4.c To: Bin Cheng Cc: "gcc-patches@gcc.gnu.org" , nd Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02033.txt.bz2 On Thu, May 25, 2017 at 8:00 PM, Bin Cheng wrote: > Hi, > I believe this tests has been wrongly modified previously. It is to test that the exit check on > pointer shouldn't be replaced by integer IV. Somehow GCC starts replacing the check on > integer IV with pointer IV. It's valid, though inefficient. And somehow we starting checking > this iv replacement. This patch rectifies it by specifically checking the check on pointer > shouldn't be replaced. So maybe it should then test that the pointer test prevails? Or rather that it doesn't replace any exit test? If 'p' changes for '_2' for unrelated reasons the pattern will be not testing what it is supposed to test... Richard. > Bootstrap and test in series on x86_64. Is it OK? > Thanks, > bin > gcc/testsuite/ChangeLog > 2017-05-11 Bin Cheng > > * gcc.dg/tree-ssa/ivopt_mult_4.c: Explicitly check comparison > on pointer should not be replaced.