From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id B354B3858D20 for ; Thu, 14 Sep 2023 10:20:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B354B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-500c37d479aso1278155e87.2 for ; Thu, 14 Sep 2023 03:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694686836; x=1695291636; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nAGa434eKwruD+aFC62qFoDff/rUIbpl+A3SAh8HJag=; b=kumO6m9n7o1x3a94pB2wN5rRdrisjeQ9mryaJwJAx2SvCZU3na1LEAAZ2B9AKrXdet n7L9BK2uyD/KrnNMPU1Lrin8WbriKnk7yUd61Am9GLVfEjwQ2QYiRS+WlKil4s+m1pOQ 2N2GIXuCbhzo8CRYhMzb0YLQtB6VRIkevuykkRF5lmvqY1VHPymwbKMr+k+zZ9Nb00zp jo9zMV7g2WynMHcbmZvUJZXYU6hZ1M5fdjts2xa336Y8cGnJvT92DmbPvF+mjAV5eY3j plUlklj/OmHTCkz+oBxpS/y6eWOaFKS5/C/81zVdkxx7bmzvlw7fI9riD24vtCdgEei2 90DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694686836; x=1695291636; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nAGa434eKwruD+aFC62qFoDff/rUIbpl+A3SAh8HJag=; b=N5gTHM2/vQnDoJ8ss4ZqkB1dMOcd/jVdgP0oyUV8mXYmTERhxlMUdk3aTIEr9uNyJA YkT2lQJvzorFiN46tuxAHSrpSYqNt/npFip8LRbhjfs87QuXxjN28ibKVBc8e04586P1 M3r+bIqC0XAOAZFFtaNsS0VE1spprTOjU4kvENtXOpfFtdRFql+M/60zGkBEqWeAKHVC /JjXxW8F0An2aSjz3i85M/MaKMD8J4ZYuMgosgfiTyACsbcdlih2YsFiMwCIzDQQ0/9d YFaLK2yGIRF3V9wQnrkda3puy1sx4oVfagUl0fOtzfuwAWhe+h3Q9eVrjGzCpO0ZgTE+ vf9A== X-Gm-Message-State: AOJu0YxlVImlv/ZLBYmkTa9wclHUPgqvHvfQBGhfjePaLipw1Ge63Tfy ex2Di7KScq1/XlEVkC9+nx9awrpdRteKC3Q2QGs= X-Google-Smtp-Source: AGHT+IFwOy//bQODar0IO5XjeYfnWywX45u0ivT8der6ky0lEckv27c3jGHw6/pWbkKwMvnLx1kO/3+Smlc0zrIEMNs= X-Received: by 2002:a05:6512:3b81:b0:500:982e:e2b4 with SMTP id g1-20020a0565123b8100b00500982ee2b4mr5332625lfv.5.1694686835785; Thu, 14 Sep 2023 03:20:35 -0700 (PDT) MIME-Version: 1.0 References: <1E30AA03-E0C1-447C-8A06-1B516B86992D@gmail.com> <20E41E5A-C9FE-4B9B-AEE6-CA8D18EC6635@gmail.com> In-Reply-To: <20E41E5A-C9FE-4B9B-AEE6-CA8D18EC6635@gmail.com> From: Richard Biener Date: Thu, 14 Sep 2023 12:18:31 +0200 Message-ID: Subject: Re: [PATCH] core: Support heap-based trampolines To: FX Coudert Cc: Jeff Law , GCC Patches , Iain Sandoe , maxim.blinov@embecosm.com, ebotcazou@adacore.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Sep 6, 2023 at 5:44=E2=80=AFPM FX Coudert wro= te: > > Hi, > > ping**2 on the revised patch, for Richard or another global reviewer. So = far all review feedback is that it=E2=80=99s a step forward, and it=E2=80= =99s been widely used for both aarch64-darwin and x86_64-darwin distributio= ns for almost three years now. > > OK to commit? I just noticed that ftrampoline-impl isn't Optimize, thus it's not streamed with LTO. How does mixing different -ftrampoline-impl for different LTO TUs behave? How does mis-specifying -ftrampoline-impl at LTO link time compared to compile-time behave? Is the state fully reflected during pre-IPA compilation and the flag not needed after that? It appears so, but did you check? OK if that's a non-issue. Thanks, Richard. > FX > > > > > Le 5 ao=C3=BBt 2023 =C3=A0 16:20, FX Coudert a = =C3=A9crit : > > > > Hi Richard, > > > > Thanks for your feedback. Here is an amended version of the patch, taki= ng into consideration your requests and the following discussion. There is = no configure option for the libgcc part, and the documentation is amended. = The patch is split into three commits for core, target and libgcc. > > > > Currently regtesting on x86_64 linux and darwin (it was fine before I s= plit up into three commits, so I=E2=80=99m re-testing to make sure I didn= =E2=80=99t screw anything up). > > > > OK to commit? > > FX >