Re: [PATCH 6/6] ipa-cp: Separate and increase the large-unit parameter

[Richard Biener <richard.guenther@gmail.com>]

On Tue, Sep 29, 2020 at 9:31 PM Jan Hubicka <hubicka@ucw.cz> wrote:
>
> >
> > gcc/ChangeLog:
> >
> > 2020-09-07  Martin Jambor  <mjambor@suse.cz>
> >
> >       * params.opt (ipa-cp-large-unit-insns): New parameter.
> >       * ipa-cp.c (get_max_overall_size): Use the new parameter.
> OK,

Maybe the IPA CP large-unit should be a factor of the large-unit
param?  Thus, make the new param ipa-cp-large-unit-factor
instead so when people increase large-unit they also get "other"
large units increased accordingly?

> thanks!
> Honza
> > ---
> >  gcc/ipa-cp.c   | 2 +-
> >  gcc/params.opt | 4 ++++
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c
> > index 12acf24c553..2152f9e5876 100644
> > --- a/gcc/ipa-cp.c
> > +++ b/gcc/ipa-cp.c
> > @@ -3448,7 +3448,7 @@ static long
> >  get_max_overall_size (cgraph_node *node)
> >  {
> >    long max_new_size = orig_overall_size;
> > -  long large_unit = opt_for_fn (node->decl, param_large_unit_insns);
> > +  long large_unit = opt_for_fn (node->decl, param_ipa_cp_large_unit_insns);
> >    if (max_new_size < large_unit)
> >      max_new_size = large_unit;
> >    int unit_growth = opt_for_fn (node->decl, param_ipa_cp_unit_growth);
> > diff --git a/gcc/params.opt b/gcc/params.opt
> > index acb59f17e45..9d177ab50ad 100644
> > --- a/gcc/params.opt
> > +++ b/gcc/params.opt
> > @@ -218,6 +218,10 @@ Percentage penalty functions containing a single call to another function will r
> >  Common Joined UInteger Var(param_ipa_cp_unit_growth) Init(10) Param Optimization
> >  How much can given compilation unit grow because of the interprocedural constant propagation (in percent).
> >
> > +-param=ipa-cp-large-unit-insns=
> > +Common Joined UInteger Var(param_ipa_cp_large_unit_insns) Optimization Init(16000) Param
> > +The size of translation unit that IPA-CP pass considers large.
> > +
> >  -param=ipa-cp-value-list-size=
> >  Common Joined UInteger Var(param_ipa_cp_value_list_size) Init(8) Param Optimization
> >  Maximum size of a list of values associated with each parameter for interprocedural constant propagation.
> > --
> > 2.28.0