From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by sourceware.org (Postfix) with ESMTPS id 67C3F3857C62 for ; Wed, 30 Sep 2020 06:35:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 67C3F3857C62 Received: by mail-ed1-x542.google.com with SMTP id l24so572635edj.8 for ; Tue, 29 Sep 2020 23:35:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zmDKxy42kFgcRo/ThVK45kPHx5mz/GVAE1GyBFQ003k=; b=QvtwtcDGv6kQJ+L3hJE525dGzmOMRiAoK1Ly5unGkYWtlk0e616iIHFXjX5+YNn1zk 0frDD8TZ6ex910Bot1WJj5cvTcdC3VG/0rQjnKJkj3zc9n+qF9tgwHaPijk8YXlAXpSm ZOVFp3pzs0f9FY4bEh2O0bEOQw1eRh0QFe4Hvj/B7iZmE+qK15aX1ZAwFk8ZKFIh3Oa9 YBJReaK1/e0hyQmp4aW19/loUXrbpj9mXrGPAAaTk8CbtNgC8vQ5Ggf/SjehH8/fw6Ze XOv81xJngYVX1+MenQtb6Fl62YKhvVTGfonDNdigFVXa1Bph7XTTZywarwe0p1oinJ04 Gulw== X-Gm-Message-State: AOAM531HvBGwIfctuA+qr38i6QWI+LEN+7twXOon3sJKHv7lSxbEah5t SPwb3UbqZ51sgKNMrcSvZkZjQYzGDMIpAcm8k8E= X-Google-Smtp-Source: ABdhPJzdgFR7GlaiUMQXNaXJl536NqiMvttWWVX2ZZg3uX4IzxLQnVWJaHDvyQQfR05yWadERBkkEwrUze4ztSLh6JY= X-Received: by 2002:aa7:c158:: with SMTP id r24mr1054113edp.61.1601447721508; Tue, 29 Sep 2020 23:35:21 -0700 (PDT) MIME-Version: 1.0 References: <5361cc8dc62a8199ab1db6cdeac4f5fc1114bcc2.1601403165.git.mjambor@suse.cz> <20200929193041.GD7702@kam.mff.cuni.cz> In-Reply-To: <20200929193041.GD7702@kam.mff.cuni.cz> From: Richard Biener Date: Wed, 30 Sep 2020 08:35:10 +0200 Message-ID: Subject: Re: [PATCH 6/6] ipa-cp: Separate and increase the large-unit parameter To: Jan Hubicka Cc: Martin Jambor , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2020 06:35:23 -0000 On Tue, Sep 29, 2020 at 9:31 PM Jan Hubicka wrote: > > > > > gcc/ChangeLog: > > > > 2020-09-07 Martin Jambor > > > > * params.opt (ipa-cp-large-unit-insns): New parameter. > > * ipa-cp.c (get_max_overall_size): Use the new parameter. > OK, Maybe the IPA CP large-unit should be a factor of the large-unit param? Thus, make the new param ipa-cp-large-unit-factor instead so when people increase large-unit they also get "other" large units increased accordingly? > thanks! > Honza > > --- > > gcc/ipa-cp.c | 2 +- > > gcc/params.opt | 4 ++++ > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c > > index 12acf24c553..2152f9e5876 100644 > > --- a/gcc/ipa-cp.c > > +++ b/gcc/ipa-cp.c > > @@ -3448,7 +3448,7 @@ static long > > get_max_overall_size (cgraph_node *node) > > { > > long max_new_size = orig_overall_size; > > - long large_unit = opt_for_fn (node->decl, param_large_unit_insns); > > + long large_unit = opt_for_fn (node->decl, param_ipa_cp_large_unit_insns); > > if (max_new_size < large_unit) > > max_new_size = large_unit; > > int unit_growth = opt_for_fn (node->decl, param_ipa_cp_unit_growth); > > diff --git a/gcc/params.opt b/gcc/params.opt > > index acb59f17e45..9d177ab50ad 100644 > > --- a/gcc/params.opt > > +++ b/gcc/params.opt > > @@ -218,6 +218,10 @@ Percentage penalty functions containing a single call to another function will r > > Common Joined UInteger Var(param_ipa_cp_unit_growth) Init(10) Param Optimization > > How much can given compilation unit grow because of the interprocedural constant propagation (in percent). > > > > +-param=ipa-cp-large-unit-insns= > > +Common Joined UInteger Var(param_ipa_cp_large_unit_insns) Optimization Init(16000) Param > > +The size of translation unit that IPA-CP pass considers large. > > + > > -param=ipa-cp-value-list-size= > > Common Joined UInteger Var(param_ipa_cp_value_list_size) Init(8) Param Optimization > > Maximum size of a list of values associated with each parameter for interprocedural constant propagation. > > -- > > 2.28.0