From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id E3BCC3858C1F for ; Mon, 14 Aug 2023 12:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3BCC3858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b9db1de50cso63243551fa.3 for ; Mon, 14 Aug 2023 05:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692014690; x=1692619490; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2qxssv4CR+uwpkhbhYE6ujMkvkApF4BMHUKEhNxWxh4=; b=Ukgw/MDFWG7OmgC4+xVzSB+bXscQ0nmo3XIpBEDS4x6K2NPvebqC3dsWV4Q6LPinMg utqUjM7C8dXgJHHugd3NsEsNc4eib9q59Z5bE99ZcyY3p6M5XphOFblmCDVLv4uKAtNw 1obBtOWWFnjrBeixz39JeDgK6ZyGt/VvwPrpCtLvu1vNCdDkNTk+e3PSI9LGbam5Y98C p1SIB0OfgfZcGYPZjMpDAzQ0WHCwyxGeho1OOQ5uWMP2JnQp/lk1FFahCkGuhmqegs6v wI/JgNxvbBlHGQC2mcJCBIFl2a9rcvotQV5sEr+yhXhbI+1vOdRlR1j8V5wXGpU3wKux jwYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692014690; x=1692619490; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qxssv4CR+uwpkhbhYE6ujMkvkApF4BMHUKEhNxWxh4=; b=cp/cwvudc0SWb+okAqmt9V7QAc3Ku7C+bBpdKz4ds1O4w3co97yPIMu1L8KDEyikoc wXJPE+ugsI6oe1kcUk62/UuaTmw32uWMfm/4m8szYewDQYwdbRfyQinbvL42oQ8y609x EoS5qspvrFcN/wvlaWefQm2+ZfNCsqglGnkypthk2wGcnCUYAVVIyi8hCcYuza1Xqb/b gsgWBsNcthd80fxm9g/9Ip6euTRKSNmeFG1OMgHVBMdzObMzyI+meJ3PbYsbqO1sHFn2 M1L3F62l08YdM8+h04q7lE8o9Id0nVVovb01+U7Qyh/IHB5yQdtBRyt8/YpMs4m9nQBY PbVw== X-Gm-Message-State: AOJu0YwT70cnom/HJhFvLSBjzzAgwB5NddIgcvr73u05EKoIjIdiKPbC JNe/yhTUfwNi1E5qBIRzJ71C7NnTpwlAIXGEZpM= X-Google-Smtp-Source: AGHT+IFrg7ONZ6RppVg2vPfw2s3j3s1GhHiaSvJqUlHgLvWLMZ9wa8zPp0REtSyW2xzBy7UOcql4iXfkCqcq8x3PbiQ= X-Received: by 2002:a2e:9850:0:b0:2b9:dfd1:3808 with SMTP id e16-20020a2e9850000000b002b9dfd13808mr6392663ljj.25.1692014690008; Mon, 14 Aug 2023 05:04:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 14 Aug 2023 14:03:33 +0200 Message-ID: Subject: Re: [PATCH] vect: Remove several useless VMAT_INVARIANT checks To: "Kewen.Lin" Cc: GCC Patches , Richard Sandiford Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 14, 2023 at 10:52=E2=80=AFAM Kewen.Lin wr= ote: > > Hi, > > In function vectorizable_load, there is one hunk which is > dedicated for the handlings on VMAT_INVARIANT and return > early, it means we shouldn't encounter any cases with > memory_access_type VMAT_INVARIANT in the following code > after that. This patch is to clean up several useless > checks on VMAT_INVARIANT. There should be no functional > changes. > > Bootstrapped and regtested on x86_64-redhat-linux, > aarch64-linux-gnu and powerpc64{,le}-linux-gnu. OK. > gcc/ChangeLog: > > * tree-vect-stmts.cc (vectorizable_load): Remove some useless che= cks > on VMAT_INVARIANT. > --- > gcc/tree-vect-stmts.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc > index 89607a98f99..d4e781531fd 100644 > --- a/gcc/tree-vect-stmts.cc > +++ b/gcc/tree-vect-stmts.cc > @@ -10499,7 +10499,7 @@ vectorizable_load (vec_info *vinfo, > tree bias =3D NULL_TREE; > if (!costing_p) > { > - if (loop_masks && memory_access_type !=3D VMAT_INVARIAN= T) > + if (loop_masks) > final_mask > =3D vect_get_loop_mask (loop_vinfo, gsi, loop_masks= , > vec_num * ncopies, vectype, > @@ -10729,7 +10729,7 @@ vectorizable_load (vec_info *vinfo, > bias =3D build_int_cst (intQI_type_node, biasval)= ; > } > > - if (final_len && memory_access_type !=3D VMAT_INVARIA= NT) > + if (final_len) > { > tree ptr > =3D build_int_cst (ref_type, align * BITS_PER_U= NIT); > -- > 2.31.1