From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id EBB153858D35 for ; Mon, 7 Mar 2022 13:48:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBB153858D35 Received: by mail-ej1-x629.google.com with SMTP id p15so32057794ejc.7 for ; Mon, 07 Mar 2022 05:48:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fbtQT2op35QNbuVBc14boFDC7DQK9ef/E1nx1Kx9rkE=; b=AdP4Sd1EePiSY01y+2TSR3tb3bag8b5T4uqhlzsFrBjbDMAKJnKdhliJJ++l3gyluN GSUtYyS9Xd0YWUi9D0WL4JG75B6UQjVkK1RqSxMMewYIkCBek7s+8akWcitzjh7REWi5 ZGYh7W7UsTbwepDpGfrfdShy9gaUWSo8APxd9nldcLXo1HfoKEiJDZ3i9tesXIHKk2jr v4xALC+xgnYKAB5v/pgnC6YX4xc6sn52AKycdiySFOgxwoMrH3YUbUqXh462FQ4DLK2E eB5inhxjEhcfoIFUXA0hqVZKCsXkKZuB2sjHdE/WO4NldRX9jhy77JCFsqZohWfGD446 Fv8A== X-Gm-Message-State: AOAM532pwWWYHEGQgMklp7EJan54XIZwvTl+0395cclDTHkRm/M4S5IQ NsV9pxq7adZ+4nw0GG7SGBAOucJstXRlTK5vnkE= X-Google-Smtp-Source: ABdhPJy+5xtiYE7u6D9iIFPpRdnAW9RFKiog8nmQSgwa+Ff0IaVjQjajUxKGNn76ClX4PdCGW4yyJ73O4yobSl0H5k0= X-Received: by 2002:a17:906:948:b0:6d6:e479:1fe4 with SMTP id j8-20020a170906094800b006d6e4791fe4mr9085564ejd.240.1646660935921; Mon, 07 Mar 2022 05:48:55 -0800 (PST) MIME-Version: 1.0 References: <65d104c2-eef6-fa92-7e6d-a42387c7526a@suse.cz> In-Reply-To: From: Richard Biener Date: Mon, 7 Mar 2022 14:48:45 +0100 Message-ID: Subject: Re: [PATCH] opts: fix -gtoggle + optimize attribute To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 13:48:58 -0000 On Fri, Mar 4, 2022 at 2:12 PM Martin Li=C5=A1ka wrote: > > On 3/1/22 09:48, Richard Biener wrote: > > I think moving flag_gtoggle handling before the flag_syntax_only handli= ng > > is a good thing. But I don't quite understand the flag_var_tracking di= sabling > > or how it worked before. > > Well, as you know, the debugging options are a can of worms. During GCC 1= 2 development I moved > most of the option logic to finish_options which is a place that is used = both for command line > option processing and optimize/target pragma/attribute processing. > > That's why we see this problem. OPT_LEVELS_1_PLUS enables flag_var_tracki= ng but we have to drop > debug debug_info_level =3D=3D DINFO_LEVEL_NONE. > > > At least I think you want to check for > > debug_info_level =3D=3D NONE, no? Why should DINFO_LEVEL_TERSE be > > special? > > No, sending updated version of the patch. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? OK. > Thanks, > Martin