From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d])
	by sourceware.org (Postfix) with ESMTPS id D46DF3858C52
	for <gcc-patches@gcc.gnu.org>; Fri, 23 Sep 2022 06:54:36 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D46DF3858C52
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x62d.google.com with SMTP id hy2so22225307ejc.8
        for <gcc-patches@gcc.gnu.org>; Thu, 22 Sep 2022 23:54:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date;
        bh=biltcv/hNL+Yp8f8EgqaoU6Be3tWN1Pioi0Wrc4U/3Q=;
        b=Ia2zCW/HvoXMUrbZFNIvhvUkm7nrI6SGEFWVpHQHCf3cjOVD68qvsaoPr5dkQ8EE0t
         BeyjpaPmnhiASVRUL44fqEi8ketSkwmbPJm/dkFhUE3ZjK1iyvlbuUiWJxriwVCMuf0h
         Frp34xYjV3fU87vnacAhzO3YvI6G65sKJaraWp0RazCjX337708Dm3BvE2+nNbJUrH5+
         0d8sK4KULV+IhfLgTrM9SQbJQLkmI8NhnvvjQza3Wadfboo0RxlWWRetxyiQu1W0L/YU
         nN5b67G1jdvGzKAUZLttFRipohihkjTWBgGah6hGqNB46NHclqMyNwnACOwIDmc8EfFK
         rhoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date;
        bh=biltcv/hNL+Yp8f8EgqaoU6Be3tWN1Pioi0Wrc4U/3Q=;
        b=2etya3mCo/ooiOB6w9TQyKPEMNk0MnDZ0w82q50sHnr/vLcrwybyvvRAiuZkQnaOWI
         b9egSgxII0bwE9niz16Drkwf5fAIVd0S+Pyv5oMQS3wBLbQjtlIJIs5IjOwhJYpp70mE
         vxPa01qaUxOzD5cBchURcmffCXyaVKjosKkdeuhQyNkxFP9fWVPEiDSCLTn9VwHU6Yib
         qe/gB6aezR4HOQdhwICj0UlsSzI/KeEx/btktyzAIcGsX1Od9WCiR/qzrYPo4hQCY0Wg
         1NFeHEVdjMwyiowTVDnXOsreduQhQrtC/aWH0t6XOj/jSV1X2J1DVnT15r9GR6Q9yRwd
         Zk9g==
X-Gm-Message-State: ACrzQf3yU5LwZp3Pf3IuydSsrL6E33K0kScR6q5feSv0Kk8mkigntq+g
	28BGK2fHWOh7uKxryRidx5po0vBOhq4jRwif7mC0t35y
X-Google-Smtp-Source: AMsMyM7HsTMRSU5Jpl4mzg2nxr2BWXLEoHHgBuval0Og5t1NhASahZpmRy2BitBKVjAUyIiGH0/YWP8i89b8KWEhnoc=
X-Received: by 2002:a17:907:9490:b0:781:c079:1294 with SMTP id
 dm16-20020a170907949000b00781c0791294mr6142932ejc.29.1663916075570; Thu, 22
 Sep 2022 23:54:35 -0700 (PDT)
MIME-Version: 1.0
References: <20220922164752.2566043-1-aldyh@redhat.com>
In-Reply-To: <20220922164752.2566043-1-aldyh@redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 23 Sep 2022 08:54:23 +0200
Message-ID: <CAFiYyc0RUb60DqOK+bwgCn5a4EMuFDC=Koy2Z=7cjH8wFSR8XQ@mail.gmail.com>
Subject: Re: [PATCH] Add debug functions for REAL_VALUE_TYPE.
To: Aldy Hernandez <aldyh@redhat.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, Sep 22, 2022 at 6:48 PM Aldy Hernandez via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> We currently have no way of dumping REAL_VALUE_TYPEs when debugging.
>
> Tested on a gdb session examining the real value 10.0:
>
> (gdb) p min
> $9 = {cl = 1, decimal = 0, sign = 0, signalling = 0, canonical = 0, uexp = 4, sig = {0, 0, 11529215046068469760}}
> (gdb) p debug (min)
> 0x0.ap+4
>
> OK for trunk?

I'd say the reference taking variant is enough (just remember to do
debug (*val)),
but OK (maybe simplify the pointer variant by forwarding instead of duplicating)

Richard.

>
> gcc/ChangeLog:
>
>         * real.cc (debug): New.
> ---
>  gcc/real.cc | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/gcc/real.cc b/gcc/real.cc
> index 73bbac645d9..a31b256a47b 100644
> --- a/gcc/real.cc
> +++ b/gcc/real.cc
> @@ -1900,6 +1900,22 @@ real_to_decimal (char *str, const REAL_VALUE_TYPE *r_orig, size_t buf_size,
>                             digits, crop_trailing_zeros, VOIDmode);
>  }
>
> +DEBUG_FUNCTION void
> +debug (const REAL_VALUE_TYPE *r)
> +{
> +  char s[60];
> +  real_to_hexadecimal (s, r, sizeof (s), 0, 1);
> +  fprintf (stderr, "%s\n", s);
> +}
> +
> +DEBUG_FUNCTION void
> +debug (const REAL_VALUE_TYPE &r)
> +{
> +  char s[60];
> +  real_to_hexadecimal (s, &r, sizeof (s), 0, 1);
> +  fprintf (stderr, "%s\n", s);
> +}
> +
>  /* Render R as a hexadecimal floating point constant.  Emit DIGITS
>     significant digits in the result, bounded by BUF_SIZE.  If DIGITS is 0,
>     choose the maximum for the representation.  If CROP_TRAILING_ZEROS,
> --
> 2.37.1
>