From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id A0CD63951C03 for ; Mon, 19 Jul 2021 14:34:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0CD63951C03 Received: by mail-ed1-x52f.google.com with SMTP id t2so23874934edd.13 for ; Mon, 19 Jul 2021 07:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U5rkwcVCRPRz7WECq6J2kYCXoX3NF59N/ZBKhqFBaH0=; b=OjmaQnfxfF333ieVl9OzP3iyz+mBR7MwZ8B8uJBXK/CWK1A24M7Fakn8HVslUWVbD+ pG3w5SSei3852sbDd3mqPF8nupNDhTUUwU6A/w1qKa+WixLssF/xXtNhPYe4tr9fd70u 1yaUI8cA3JeS8WlkgLjw4ZElt5bp0wDk7YUw+xA5qHj1kjWwn1gjUxkZdq2mCE4mgUcN +iJlYdANfiugp4M1VEAM6gdn89rsHclBvBLVxTDzBdd0D7NPmCkE1nebuqSv7UdiTnI+ ZUd/Y4ssmXmPTa6P3dW39pCxJtN6A5FZUpuLlFSFJF3Z0CYT7TZI23lR2fJcCpei8h9q YB9Q== X-Gm-Message-State: AOAM530QCzq9cDsXocYEVxvy8wjdnrj6gClCBtK6/skipOHp0ZEMAdDv LGQA8HDqaoIYNNb8E77vV6pl+u2GCc8r80uzcms= X-Google-Smtp-Source: ABdhPJyhEXa/0rP5K5Kv9qb4WDlyaT1zMJCH4EqXHJ69MaGd16zsfsAJlDfkKmRkIoQki5ryYZqKs3jE/4aIZghvdY0= X-Received: by 2002:a50:8d4e:: with SMTP id t14mr24701135edt.138.1626705257266; Mon, 19 Jul 2021 07:34:17 -0700 (PDT) MIME-Version: 1.0 References: <0a8b77ba-1d54-1eff-b54d-d2cb1e769e09@linux.ibm.com> In-Reply-To: <0a8b77ba-1d54-1eff-b54d-d2cb1e769e09@linux.ibm.com> From: Richard Biener Date: Mon, 19 Jul 2021 16:34:06 +0200 Message-ID: Subject: Re: [RFC/PATCH] Use range-based for loops for traversing loops To: "Kewen.Lin" Cc: GCC Patches , Martin Sebor , Richard Sandiford , Jakub Jelinek , Trevor Saunders , Segher Boessenkool , Jonathan Wakely Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 14:34:20 -0000 On Mon, Jul 19, 2021 at 8:20 AM Kewen.Lin wrote: > > Hi, > > This patch follows Martin's suggestion here[1], to support > range-based for loops for traversing loops, analogously to > the patch for vec[2]. > > Bootstrapped and regtested on powerpc64le-linux-gnu P9, > x86_64-redhat-linux and aarch64-linux-gnu, also > bootstrapped on ppc64le P9 with bootstrap-O3 config. > > Any comments are appreciated. Since you are touching all FOR_EACH_LOOP please make implicit 'cfun' uses explicit. I'm not sure ALL_LOOPS should scream, I think all_loops (function *, flags) would be nicer. Note I'm anticipating iteration over a subset of the loop tree which would ask for specifying the 'root' of the loop tree to iterate over so it could be loops_list (class loop *root, unsigned flags) and the "all" cases use loops_list (loops_for_fn (cfun), flags) then. Providing an overload with struct function is of course OK. Richard. > BR, > Kewen > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573424.html > [2] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572315.html > ----- > gcc/ChangeLog: > > * cfgloop.h (class loop_iterator): Rename to ... > (class loops_list): ... this. > (loop_iterator::next): Rename to ... > (loops_list::iterator::fill_curr_loop): ... this and adjust. > (loop_iterator::loop_iterator): Rename to ... > (loops_list::loops_list): ... this and adjust. > (FOR_EACH_LOOP): Rename to ... > (ALL_LOOPS): ... this. > (FOR_EACH_LOOP_FN): Rename to ... > (ALL_LOOPS_FN): this. > (loops_list::iterator): New class. > (loops_list::begin): New function. > (loops_list::end): Likewise. > * cfgloop.c (flow_loops_dump): Adjust FOR_EACH_LOOP* with ALL_LOOPS*. > (sort_sibling_loops): Likewise. > (disambiguate_loops_with_multiple_latches): Likewise. > (verify_loop_structure): Likewise. > * cfgloopmanip.c (create_preheaders): Likewise. > (force_single_succ_latches): Likewise. > * config/aarch64/falkor-tag-collision-avoidance.c > (execute_tag_collision_avoidance): Likewise. > * config/mn10300/mn10300.c (mn10300_scan_for_setlb_lcc): Likewise. > * config/s390/s390.c (s390_adjust_loops): Likewise. > * doc/loop.texi: Likewise. > * gimple-loop-interchange.cc (pass_linterchange::execute): Likewise. > * gimple-loop-jam.c (tree_loop_unroll_and_jam): Likewise. > * gimple-loop-versioning.cc (loop_versioning::analyze_blocks): Likewise. > (loop_versioning::make_versioning_decisions): Likewise. > * gimple-ssa-split-paths.c (split_paths): Likewise. > * graphite-isl-ast-to-gimple.c (graphite_regenerate_ast_isl): Likewise. > * graphite.c (canonicalize_loop_form): Likewise. > (graphite_transform_loops): Likewise. > * ipa-fnsummary.c (analyze_function_body): Likewise. > * ipa-pure-const.c (analyze_function): Likewise. > * loop-doloop.c (doloop_optimize_loops): Likewise. > * loop-init.c (loop_optimizer_finalize): Likewise. > (fix_loop_structure): Likewise. > * loop-invariant.c (calculate_loop_reg_pressure): Likewise. > (move_loop_invariants): Likewise. > * loop-unroll.c (decide_unrolling): Likewise. > (unroll_loops): Likewise. > * modulo-sched.c (sms_schedule): Likewise. > * predict.c (predict_loops): Likewise. > (pass_profile::execute): Likewise. > * profile.c (branch_prob): Likewise. > * sel-sched-ir.c (sel_finish_pipelining): Likewise. > (sel_find_rgns): Likewise. > * tree-cfg.c (replace_loop_annotate): Likewise. > (replace_uses_by): Likewise. > (move_sese_region_to_fn): Likewise. > * tree-if-conv.c (pass_if_conversion::execute): Likewise. > * tree-loop-distribution.c (loop_distribution::execute): Likewise. > * tree-parloops.c (parallelize_loops): Likewise. > * tree-predcom.c (tree_predictive_commoning): Likewise. > * tree-scalar-evolution.c (scev_initialize): Likewise. > (scev_reset): Likewise. > * tree-ssa-dce.c (find_obviously_necessary_stmts): Likewise. > * tree-ssa-live.c (remove_unused_locals): Likewise. > * tree-ssa-loop-ch.c (ch_base::copy_headers): Likewise. > * tree-ssa-loop-im.c (analyze_memory_references): Likewise. > (tree_ssa_lim_initialize): Likewise. > * tree-ssa-loop-ivcanon.c (canonicalize_induction_variables): Likewise. > * tree-ssa-loop-ivopts.c (tree_ssa_iv_optimize): Likewise. > * tree-ssa-loop-manip.c (get_loops_exits): Likewise. > * tree-ssa-loop-niter.c (estimate_numbers_of_iterations): Likewise. > (free_numbers_of_iterations_estimates): Likewise. > * tree-ssa-loop-prefetch.c (tree_ssa_prefetch_arrays): Likewise. > * tree-ssa-loop-split.c (tree_ssa_split_loops): Likewise. > * tree-ssa-loop-unswitch.c (tree_ssa_unswitch_loops): Likewise. > * tree-ssa-loop.c (gate_oacc_kernels): Likewise. > (pass_scev_cprop::execute): Likewise. > * tree-ssa-propagate.c (clean_up_loop_closed_phi): Likewise. > * tree-ssa-sccvn.c (do_rpo_vn): Likewise. > * tree-ssa-threadupdate.c > (jump_thread_path_registry::thread_through_all_blocks): Likewise. > * tree-vectorizer.c (vectorize_loops): Likewise. > * tree-vrp.c (vrp_asserts::find_assert_locations): Likewise.