* [PATCH, GCC/testsuite] Fix gen-vect-26.c requirements
@ 2017-06-13 9:10 Thomas Preudhomme
2017-06-13 10:16 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Preudhomme @ 2017-06-13 9:10 UTC (permalink / raw)
To: Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi,
gen-vect-26.c tests the vectorizer but only requires vect_cmdline_needed
effective target. It should also depends on vect_int to make sure a
vector unit is available on the target. This patch fixes that.
ChangeLog entry is as follows:
*** gcc/testsuite/ChangeLog ***
2017-06-05 Thomas Preud'homme <thomas.preudhomme@arm.com>
* gcc.dg/tree-ssa/gen-vect-26.c: Also require vect_int effective
target.
Testing: Testcase is now skipped when targeting Cortex-M3.
Is this ok for trunk?
Best regards,
Thomas
[-- Attachment #2: fix_gen-vect-26.patch --]
[-- Type: text/x-patch, Size: 673 bytes --]
diff --git a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c
index 8e5f1410612b075914000dcdc643b2838ee3dcd9..8edeb0bbfd31b3926382da27bfafa4f331066ba9 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-26.c
@@ -1,4 +1,4 @@
-/* { dg-do run { target vect_cmdline_needed } } */
+/* { dg-do run { target { vect_cmdline_needed && vect_int } } } */
/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -fvect-cost-model=dynamic" } */
/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details -fvect-cost-model=dynamic -mno-sse" { target { i?86-*-* x86_64-*-* } } } */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, GCC/testsuite] Fix gen-vect-26.c requirements
2017-06-13 9:10 [PATCH, GCC/testsuite] Fix gen-vect-26.c requirements Thomas Preudhomme
@ 2017-06-13 10:16 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2017-06-13 10:16 UTC (permalink / raw)
To: Thomas Preudhomme
Cc: Kyrill Tkachov, Ramana Radhakrishnan, Richard Earnshaw, gcc-patches
On Tue, Jun 13, 2017 at 11:10 AM, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
> Hi,
>
> gen-vect-26.c tests the vectorizer but only requires vect_cmdline_needed
> effective target. It should also depends on vect_int to make sure a
> vector unit is available on the target. This patch fixes that.
>
> ChangeLog entry is as follows:
>
> *** gcc/testsuite/ChangeLog ***
>
> 2017-06-05 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * gcc.dg/tree-ssa/gen-vect-26.c: Also require vect_int effective
> target.
>
>
> Testing: Testcase is now skipped when targeting Cortex-M3.
>
> Is this ok for trunk?
No -- the test tests for generic vectorization using integer mode vectors. See
how we pass -mno-sse on x86_64.
Richard.
> Best regards,
>
> Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-13 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 9:10 [PATCH, GCC/testsuite] Fix gen-vect-26.c requirements Thomas Preudhomme
2017-06-13 10:16 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).