From: Richard Biener <richard.guenther@gmail.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: "Dominique d'Humières" <dominiq@lps.ens.fr>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix false -Wodr warnings
Date: Tue, 16 Apr 2019 13:02:00 -0000 [thread overview]
Message-ID: <CAFiYyc0VDjs-u-1JpDb8XuxmhAt0Gs+Vj=3Tw6fiK7yGH6okSw@mail.gmail.com> (raw)
In-Reply-To: <20190416125114.uofbvksbpxbzo5au@kam.mff.cuni.cz>
On Tue, Apr 16, 2019 at 2:51 PM Jan Hubicka <hubicka@ucw.cz> wrote:
>
> > Hi Jan,
> >
> > The test causes
> >
> > WARNING: lto.exp does not support dg-do
> > WARNING: lto.exp does not support dg-options in primary source file
> >
> > This is fixed by the following patch
> >
> > --- ../_clean/gcc/testsuite/g++.dg/lto/pr89358_0.C 2019-04-15 00:04:48.000000000 +0200
> > +++ gcc/testsuite/g++.dg/lto/pr89358_0.C 2019-04-16 13:13:14.000000000 +0200
> > @@ -1,5 +1,5 @@
> > -/* { dg-do link } */
> > -/* { dg-options "-std=c++17" } */
> > +/* { dg-lto-do link } */
> > +/* { dg-lto-options "-std=c++17" } */
>
> Thanks, this changle is OK.
> Honza
> > #include <map>
> >
> > extern void test();
> > --- ../_clean/gcc/testsuite/g++.dg/lto/pr89358_1.C 2019-04-15 00:04:48.000000000 +0200
> > +++ gcc/testsuite/g++.dg/lto/pr89358_1.C 2019-04-16 13:14:44.000000000 +0200
> > @@ -1,4 +1,3 @@
> > -/* { dg-options "-std=c++14" } */
But you should leave this one in place, otherwise it will no longer
test what it was supposed to test.
Richard.
> > #include <map>
> >
> > void test()
> >
> > TIA
> >
> > Dominique
next prev parent reply other threads:[~2019-04-16 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 12:51 Dominique d'Humières
2019-04-16 12:55 ` Jan Hubicka
2019-04-16 13:02 ` Richard Biener [this message]
2019-04-16 13:08 ` Jakub Jelinek
2019-04-16 14:18 ` Dominique d'Humières
2020-01-23 13:53 ` Thomas Schwinge
-- strict thread matches above, loose matches on Subject: below --
2019-04-15 6:48 Jan Hubicka
2019-04-15 12:06 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0VDjs-u-1JpDb8XuxmhAt0Gs+Vj=3Tw6fiK7yGH6okSw@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).