From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-499315-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28632 invoked by alias); 16 Apr 2019 13:01:43 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 28623 invoked by uid 89); 16 Apr 2019 13:01:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-lf1-f47.google.com
Received: from mail-lf1-f47.google.com (HELO mail-lf1-f47.google.com) (209.85.167.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Apr 2019 13:01:41 +0000
Received: by mail-lf1-f47.google.com with SMTP id w23so15919491lfc.9        for <gcc-patches@gcc.gnu.org>; Tue, 16 Apr 2019 06:01:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=5n13Ky1uG8hDHcdDu+26+qh0osjJPeR+LENGI178m1E=;        b=WHwg+8LVY3oFeioLEKM8yoQ3Vf/FvaM1btku8txnYxpSnCap/W4mAVwrzJpc++XtIX         EpJ6zsq2LvQK78hNfiLY9pFwYQ1wrLE0DKQ7nqayWH/tvX3y9ifvP5Bwirg1SFbtzOQS         bqMWAvIJi4pGxjVJ2HDpAXqH4NLvYmEDfjysOE/NsfSEorW9iIQgAw5psz+TfGNaLTzp         UrvvvT3r1iEvC6tPzfiykMeswlBS4DWx7tw1a0ZWajHXSHO6qLBtPknlx9/4e1rsepWv         lnOcd1UtWRM62RQWfweUQa2AaMZNS6d0xoMISLI/ExVYEnXu21X7K9maPFpfNESXGvBn         XzTw==
MIME-Version: 1.0
References: <553C9698-9DAE-4C8F-A7EE-2402EBA68934@lps.ens.fr> <20190416125114.uofbvksbpxbzo5au@kam.mff.cuni.cz>
In-Reply-To: <20190416125114.uofbvksbpxbzo5au@kam.mff.cuni.cz>
From: Richard Biener <richard.guenther@gmail.com>
Date: Tue, 16 Apr 2019 13:02:00 -0000
Message-ID: <CAFiYyc0VDjs-u-1JpDb8XuxmhAt0Gs+Vj=3Tw6fiK7yGH6okSw@mail.gmail.com>
Subject: Re: Fix false -Wodr warnings
To: Jan Hubicka <hubicka@ucw.cz>
Cc: =?UTF-8?Q?Dominique_d=27Humi=C3=A8res?= <dominiq@lps.ens.fr>, 	gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2019-04/txt/msg00639.txt.bz2

On Tue, Apr 16, 2019 at 2:51 PM Jan Hubicka <hubicka@ucw.cz> wrote:
>
> > Hi Jan,
> >
> > The test causes
> >
> > WARNING: lto.exp does not support dg-do
> > WARNING: lto.exp does not support dg-options in primary source file
> >
> > This is fixed by the following patch
> >
> > --- ../_clean/gcc/testsuite/g++.dg/lto/pr89358_0.C    2019-04-15 00:04:48.000000000 +0200
> > +++ gcc/testsuite/g++.dg/lto/pr89358_0.C      2019-04-16 13:13:14.000000000 +0200
> > @@ -1,5 +1,5 @@
> > -/* { dg-do link } */
> > -/* { dg-options "-std=c++17"  } */
> > +/* { dg-lto-do link } */
> > +/* { dg-lto-options "-std=c++17"  } */
>
> Thanks, this changle is OK.
> Honza
> >  #include <map>
> >
> >  extern void test();
> > --- ../_clean/gcc/testsuite/g++.dg/lto/pr89358_1.C    2019-04-15 00:04:48.000000000 +0200
> > +++ gcc/testsuite/g++.dg/lto/pr89358_1.C      2019-04-16 13:14:44.000000000 +0200
> > @@ -1,4 +1,3 @@
> > -/* { dg-options "-std=c++14"  } */

But you should leave this one in place, otherwise it will no longer
test what it was supposed to test.

Richard.

> >  #include <map>
> >
> >  void test()
> >
> > TIA
> >
> > Dominique