public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	"hernandez, aldy" <aldyh@redhat.com>
Subject: Re: [PATCH 3/3] tree-optimization/108385 - Add op2_range to pointer_plus.
Date: Tue, 31 Jan 2023 11:24:52 +0100	[thread overview]
Message-ID: <CAFiYyc0W7q3gt82UMKXqKq2k1a-rcUFxEAQfwCdp3p+nQmoGZA@mail.gmail.com> (raw)
In-Reply-To: <64ec68a2-7a9f-4c20-0abe-7d36d7707ee4@redhat.com>

On Mon, Jan 30, 2023 at 8:47 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Implement op2_range for pointer_plus to determine the offset (operand 2)
> is zero or non-zero based on equality/inequality between the LHS and op1.
>
> Fairly trivial fix for the PR, dependent on the first patch in the set
> as it uses an accurate relation_trio in GORI to determine if LHS == OP1.
>
>
> There was one tweak to GORI in that we use to stop calculating when the
> LHS was varying.  THis PR also exposed a case where the LHS is varying,
> but a relation between the operands can still cause us to find a useful
> result...  ie
>
> VARYING = VARYING + OFFSET when LHS and OP1 are equal can produce a
> non-zero OFFSET calculation.
>
> Bootstraps on x86_64-pc-linux-gnu with no regressions. OK for trunk?

OK for the series.

Thanks,
Richard.

>
> Andrew
>

      reply	other threads:[~2023-01-31 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 19:46 Andrew MacLeod
2023-01-31 10:24 ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc0W7q3gt82UMKXqKq2k1a-rcUFxEAQfwCdp3p+nQmoGZA@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).