From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-490434-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 122473 invoked by alias); 19 Nov 2018 14:43:39 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 122462 invoked by uid 89); 19 Nov 2018 14:43:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=tkachov, kyrill, Hx-languages-length:1055, Tkachov
X-HELO: mail-lj1-f193.google.com
Received: from mail-lj1-f193.google.com (HELO mail-lj1-f193.google.com) (209.85.208.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Nov 2018 14:43:36 +0000
Received: by mail-lj1-f193.google.com with SMTP id k19-v6so26330990lji.11        for <gcc-patches@gcc.gnu.org>; Mon, 19 Nov 2018 06:43:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=Dn6frObKrflV8rVnxGQr5udUG32NaEg31IdGDn+5bks=;        b=l8RO7oDjHDpAgZxOBpRF4qiw2u53vwftsfnkN7ReidHPzrebXHQ/dFhen7+Nhg1STV         TrDPvaRVMyRVab10gsyIOt9FNg85gMihXTyjV+3Dbmw2Ob4miAAR+uFfGYWYH3tf2QAZ         eBZX/ey2mk+ORX/MBc2r+KOvUUGf/SE39rFOa8cUvHDZGGFls/NRHfaDSW0hKDNdu4js         WmxEEgW7FXgVzHH9Kvre1epUdUszqW9Y0njtCBge3DaJNLA4P5mG440Qc5896mQrICNN         RKcAGdtrwEfav69a1x3jX/Ei6MfxxnyLcRATpI+lWPwGAF0RoubatnomtOTdyTh1scNh         Rd+Q==
MIME-Version: 1.0
References: <5BE565CE.5000709@foss.arm.com> <CAFiYyc2fZ4WTdguC9RjLWfYTiUK1t=Gd7W7mVmA2qvA1t2vjuA@mail.gmail.com> <5BE5CA6D.9060408@foss.arm.com> <CAFiYyc1ojB9VFk63u7PG6O-fo4O64ufOCfEm__LGu_MrzEYYAg@mail.gmail.com> <5BE9C452.3080709@foss.arm.com> <CAFiYyc1VTDC3==EYRNK=AbO-fe_TMu-BgvjE5LOsrFhLaxb9jA@mail.gmail.com> <5BEA9631.1070500@foss.arm.com> <CAFiYyc1nHvBf+TvKjOgaHYy3rJD2e9X7hbDy=eQOBOkZdX7KxQ@mail.gmail.com> <5BEA9DF8.2030004@foss.arm.com> <CAFiYyc22sdyiUGbVzboJ977QU9mS-oj1hToxkxUUY3y6cjdj4w@mail.gmail.com> <CAFiYyc1N1Jq_u=TbGxt3HK_6ewt4_e3A-cW5VYfaTX78rEdEDg@mail.gmail.com> <5BEF0622.80405@foss.arm.com>
In-Reply-To: <5BEF0622.80405@foss.arm.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Mon, 19 Nov 2018 14:43:00 -0000
Message-ID: <CAFiYyc0WSaMYmdt8AxpuDjMt+C_1basWjA_AvXpA=KsrZe6Wxg@mail.gmail.com>
Subject: Re: [PATCH] Disable unrolling for loops vectorised with non-constant VF (was: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64)
To: kyrylo.tkachov@foss.arm.com
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Marcus Shawcroft <marcus.shawcroft@arm.com>, 	Richard Earnshaw <richard.earnshaw@arm.com>, James Greenhalgh <james.greenhalgh@arm.com>, 	Richard Sandiford <richard.sandiford@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2018-11/txt/msg01636.txt.bz2

On Fri, Nov 16, 2018 at 7:02 PM Kyrill Tkachov
<kyrylo.tkachov@foss.arm.com> wrote:
>
> Hi all,
>
> This is an alternative to https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00694.html
> As richi suggested, this disables unrolling of loops vectorised with variable-length SVE
> in the vectoriser itself through the loop->unroll member.
>
> It took me a few tries to get it right, as it needs to be set to '1' to disable unrolling,
> the rationale for that mechanism is described in the comment in cfgloop.h.
>
> Bootstrapped and tested on aarch64-none-linux-gnu.
>
> Is this ok for trunk?

OK.

Richard.

> Thanks,
> Kyrill
>
> 2018-11-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * tree-vect-loop.c (vect_transform_loop): Disable further unrolling
>      of the loop if vf is non-constant.
>
> 2018-11-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * gcc.target/aarch64/sve/unroll-1.c: New test.