From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id B47973858C2F for ; Wed, 2 Nov 2022 08:29:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B47973858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52a.google.com with SMTP id a5so25237190edb.11 for ; Wed, 02 Nov 2022 01:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+cftt8l/V9HrnvSPORbVGzi9b5dSVgpXFpbX7ptZlxA=; b=q0mj9WRuWx66QOFoG7N86LZ5on+ZMc1nU7ftmpSaB+IJEVMx18MSP53E4Mo3MLywgY HFv3ZlVYiPdDVicOfdUX+Z5fXZpJY1wbcCV5P4DHbLKuo9xthgAJ+IdBasXvg2fAA0X1 mm4iReU+s/IEshP9uX1G1VWZ4nVSMeZ9f3CHiLCS6WkUyyMeb1zr26Vr64wiEQthQNDo YRCbOIc3HYwLDXXmj+9UyjJo3mt+Kk9OW4Qiz50ecr+CIYNeFHa30qruCwNIuvAw9Cgq GwiTwbiYg0nDlxZ53QjAYWdt53gUjAJaal1Hcs4CXxwCc+viOql77Mm7vIFNmANJSxh3 Z5sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+cftt8l/V9HrnvSPORbVGzi9b5dSVgpXFpbX7ptZlxA=; b=6iT44rZViy6ZWcqtF8W395sVWCqU3kR3g0QfUMqZEC6m/TorpU8c2QTTEvOCAFTJxx ZXTkxDJIGJmt5gmfUoQOdbqsp2KYpgSpkJqQatLcMVKNwlD354I0C2oZSW/kjWEe/Dvf T8tHsxaxTGCVd9/k0UWLdIk8S4Jv1+3u6cvvYqpW8Dn4ZidDnGqgGyRH9a0riAVO1Kji AUuOQwIF9UScH+3xrGkcVPXe+DSQM+QV2959VvjqY5c4TW4uup6i4Ez87vaO+PpKnklC yUqtcr2G+q7wXTLexzgp32YA13KYZ0DeXrgpVibFR82+fZHR27qrW7lE4Ajky2xS2K2v zioQ== X-Gm-Message-State: ACrzQf3QKQOOu7tic3onofRTEvja68OlkI03P3cxm+et4uQMcSQ6aAp6 3YYFY7sw7TxhJQ1xzFdxeH7WouSYSx5G3+iIqhk= X-Google-Smtp-Source: AMsMyM5hnkq3mdehH2YWZJbIbGGqOIDXZmgB3qNJj9S+8znWBP9M95TyBqK14wY+bNKvD1hiHi8aGWdzOLMW/1+qQLg= X-Received: by 2002:a05:6402:550c:b0:443:7d15:d57f with SMTP id fi12-20020a056402550c00b004437d15d57fmr23442591edb.147.1667377761288; Wed, 02 Nov 2022 01:29:21 -0700 (PDT) MIME-Version: 1.0 References: <3fac9b35-b170-1af7-f4d2-796f9be816bf@linux.ibm.com> In-Reply-To: <3fac9b35-b170-1af7-f4d2-796f9be816bf@linux.ibm.com> From: Richard Biener Date: Wed, 2 Nov 2022 09:29:09 +0100 Message-ID: Subject: Re: [PATCH] testsuite: Fix gen-vect-34.c with vect_masked_load [PR106806] To: "Kewen.Lin" Cc: GCC Patches , Richard Sandiford , Peter Bergner , Segher Boessenkool Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 2, 2022 at 9:03 AM Kewen.Lin wrote: > > Hi, > > This is to fix the failure on powerpc as reported in PR106806, > the test case requires tree ifcvt pass to perform on that loop, > and it relies on masked_load support. The fix is to guard the > expected scan with vect_masked_load effective target. > > As tested on powerpc64{,le}-linux-gnu and aarch64-linux-gnu > (cfarm machine), the failures were gone. But on > x86_64-redhat-linux (cfarm machine) the result becomes from > PASS to N/A. I think it's expected since that machine doesn't > support AVX by default so both check_avx_available and > vect_masked_load fail, it should work fine on machines with > default AVX support, or if we adjust the current > check_avx_available with current_compiler_flags. > > Is it ok for trunk? OK > BR, > Kewen > ----- > PR testsuite/106806 > > gcc/testsuite/ChangeLog: > > * gcc.dg/tree-ssa/gen-vect-34.c: Adjust with vect_masked_load > effective target. > --- > gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c > index 41877e05efd..c2e5dfea35f 100644 > --- a/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c > +++ b/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-34.c > @@ -13,4 +13,4 @@ float summul(int n, float *arg1, float *arg2) > return res1; > } > > -/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target { ! { avr-*-* pru-*-* riscv*-*-* } } } } } */ > +/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" { target vect_masked_load } } } */ > -- > 2.27.0