From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70742 invoked by alias); 16 Nov 2015 11:12:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70733 invoked by uid 89); 16 Nov 2015 11:12:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f172.google.com Received: from mail-yk0-f172.google.com (HELO mail-yk0-f172.google.com) (209.85.160.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 16 Nov 2015 11:12:21 +0000 Received: by ykdr82 with SMTP id r82so232002190ykd.3 for ; Mon, 16 Nov 2015 03:12:19 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.129.46.212 with SMTP id u203mr37765537ywu.147.1447672339235; Mon, 16 Nov 2015 03:12:19 -0800 (PST) Received: by 10.37.93.11 with HTTP; Mon, 16 Nov 2015 03:12:19 -0800 (PST) In-Reply-To: <5648408B.9040107@iki.fi> References: <5648408B.9040107@iki.fi> Date: Mon, 16 Nov 2015 11:12:00 -0000 Message-ID: Subject: Re: [PATCH] Fix inconsistent use of integer types in gcc/lto-streamer-out.c From: Richard Biener To: Andris Pavenis Cc: GCC Patches , DJ Delorie Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01920.txt.bz2 On Sun, Nov 15, 2015 at 9:21 AM, Andris Pavenis wrote: > This fixes use of pointers different unsigned integer types as function > parameter. > Function prototype is (see gcc/tree-streamer.h): > > bool streamer_tree_cache_lookup (struct streamer_tree_cache_d *, tree, > unsigned *); > > gcc/lto-streamer-out.c passes uint32_t int * as parameter to this method in > 2 places. > Current type unisgned is used elsewhere in the same file. > > uint32_t is not guaranteed to be the same as unsigned (for DJGPP uint32_t is > actually > unsigned long). That causes compile failure for DJGPP native build. Ok. Thanks, Richard. > Andris > > 2015-11-15 Andris Pavenis > > * gcc/lto-streamer-out.c (write_global_references): Adjust integer type > (lto_output_decl_state_refs): Likewise >