From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id CD8343858401 for ; Mon, 8 Nov 2021 11:09:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD8343858401 Received: by mail-ed1-x52a.google.com with SMTP id v11so58262947edc.9 for ; Mon, 08 Nov 2021 03:09:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FmWEPEHKnQRWOQz205RZrGINaW5jAqDOX0QfxMSGs+8=; b=nJva+l48g1LNKpjUjuv8SHDB6jd1Jrjz+mh3h/fKS610flPsQgIVRe/bKU7A5avHQU /obluISpw1h6e/3oCd4WzUNInyAfM5IfHSJ8PgGyO1ASR/pquAgNFvJdg8hLwy/TeMeb XwJZJ5rjWjZFDh2cCwryZzCdDL6jsCu22SkE1pUZLh7+rnTQ7l6RYqnEFOaxAUrxLLAI pYpTgzMToAM7WqX7T5/YdieP12lK6R5r4+XWPb+zPFUxL8IIYoP0JrERg1KixBPlw7VR IKKqHf6/8Jil+vCfopoxz4goOsrwE+y8KCZRpgdTGT/Bze9WD5K+Z8OJNLszuqzDGylG y3ow== X-Gm-Message-State: AOAM531l7zijYV1rQK5hforyexyqRRqKntgn5q8OPdAIvw8xk/wkgfve p8krYZd+YDfhHPb37O1eUZLomNsi/bsvBKqJYJ4= X-Google-Smtp-Source: ABdhPJx2IPil83j1TnRn9f60yLQbcTTCJp3edw7cYrtYHtWLUhy0VOXLBqtJeb1I0XhLXX4UuIlLW2ia3ZRnVcTuDO4= X-Received: by 2002:a17:907:6d28:: with SMTP id sa40mr68220110ejc.201.1636369765764; Mon, 08 Nov 2021 03:09:25 -0800 (PST) MIME-Version: 1.0 References: <51aaa2bc-f5d7-761e-79cb-c3fb9b395f1a@suse.cz> <20211105173055.GA92445@kam.mff.cuni.cz> <20e3ce3c-c841-1263-79b4-087b40190948@suse.cz> <20211108110113.GA57526@kam.mff.cuni.cz> In-Reply-To: <20211108110113.GA57526@kam.mff.cuni.cz> From: Richard Biener Date: Mon, 8 Nov 2021 12:09:15 +0100 Message-ID: Subject: Re: [PATCH] gcov-profile: Fix -fcompare-debug with -fprofile-generate [PR100520] To: Jan Hubicka Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 11:09:28 -0000 On Mon, Nov 8, 2021 at 12:01 PM Jan Hubicka via Gcc-patches wrote: > > > On 11/5/21 18:30, Jan Hubicka wrote: > > > every gcc source looks like bit of overkill given that is can be open > > > coded in 3 statements? > > > > Why? It's a static inline function with few statements. I don't want to copy&paste > > the same code at every location. I bet there must quite some open-coded implementations > > of endswith in the GCC source code. > > I guess it is a matter of taste, but to me system.h should not be > universal include bringing a lot of unrelated things because in long > term it is how precompiled headers came to be. In theory such random > generally useful things probably would belong to libiberty, but that > also seems but of overkill to me. > > Anyway I guess we need someone with approval right to system.h to OK > that. I see there is already startswith so having endwith is probably > not too bad. OK. Richard. > Honza > > > > Martin