* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
@ 2014-05-26 9:00 Dominique Dhumieres
2014-05-26 9:16 ` Andrew Pinski
0 siblings, 1 reply; 10+ messages in thread
From: Dominique Dhumieres @ 2014-05-26 9:00 UTC (permalink / raw)
To: gcc-patches; +Cc: richard.guenther, hubicka
r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
libgfortran/configure defines HAVE_STRNLEN on targets supporting it.
The same revision also breaks the test g++.dg/tls/diag-1.C
/opt/gcc/work/gcc/testsuite/g++.dg/tls/diag-1.C:31:1: internal compiler error: in symtab_get_node, at cgraph.h:1021
TIA,
Dominique
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-05-26 9:00 [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags Dominique Dhumieres
@ 2014-05-26 9:16 ` Andrew Pinski
2014-05-26 9:29 ` Christophe Lyon
2014-05-28 7:26 ` Thomas Schwinge
0 siblings, 2 replies; 10+ messages in thread
From: Andrew Pinski @ 2014-05-26 9:16 UTC (permalink / raw)
To: Dominique Dhumieres; +Cc: GCC Patches, Richard Guenther, Jan Hubicka
On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
>
> ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
strnlen should be declared in include/libiberty.h if there is no
declaration as libiberty support is already there. That should be a
simple fix.
Thanks,
Andrew Pinski
>
> libgfortran/configure defines HAVE_STRNLEN on targets supporting it.
>
> The same revision also breaks the test g++.dg/tls/diag-1.C
>
> /opt/gcc/work/gcc/testsuite/g++.dg/tls/diag-1.C:31:1: internal compiler error: in symtab_get_node, at cgraph.h:1021
>
> TIA,
>
> Dominique
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-05-26 9:16 ` Andrew Pinski
@ 2014-05-26 9:29 ` Christophe Lyon
2014-05-26 16:32 ` Jan Hubicka
2014-05-28 7:26 ` Thomas Schwinge
1 sibling, 1 reply; 10+ messages in thread
From: Christophe Lyon @ 2014-05-26 9:29 UTC (permalink / raw)
To: Andrew Pinski
Cc: Dominique Dhumieres, GCC Patches, Richard Guenther, Jan Hubicka
On my side, I can see that r210901 breaks AArch64 compiler build:
gcc/config/aarch64/aarch64.c: In function ‘void
aarch64_elf_asm_named_section(const char*, unsigned int, tree_node*)’:
gcc/config/aarch64/aarch64.c:8136: error: ‘decl_comdat_group’ was not
declared in this scope
Christophe.
On 26 May 2014 11:16, Andrew Pinski <pinskia@gmail.com> wrote:
> On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>> r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
>>
>> ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
>
> strnlen should be declared in include/libiberty.h if there is no
> declaration as libiberty support is already there. That should be a
> simple fix.
>
> Thanks,
> Andrew Pinski
>
>>
>> libgfortran/configure defines HAVE_STRNLEN on targets supporting it.
>>
>> The same revision also breaks the test g++.dg/tls/diag-1.C
>>
>> /opt/gcc/work/gcc/testsuite/g++.dg/tls/diag-1.C:31:1: internal compiler error: in symtab_get_node, at cgraph.h:1021
>>
>> TIA,
>>
>> Dominique
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-05-26 9:29 ` Christophe Lyon
@ 2014-05-26 16:32 ` Jan Hubicka
0 siblings, 0 replies; 10+ messages in thread
From: Jan Hubicka @ 2014-05-26 16:32 UTC (permalink / raw)
To: Christophe Lyon
Cc: Andrew Pinski, Dominique Dhumieres, GCC Patches,
Richard Guenther, Jan Hubicka
> On my side, I can see that r210901 breaks AArch64 compiler build:
> gcc/config/aarch64/aarch64.c: In function ‘void
> aarch64_elf_asm_named_section(const char*, unsigned int, tree_node*)’:
> gcc/config/aarch64/aarch64.c:8136: error: ‘decl_comdat_group’ was not
> declared in this scope
This sould be fixed by adding #include "cgraph.h" into aarch64.c
I will look into the strnlen issue.
Honza
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-05-26 9:16 ` Andrew Pinski
2014-05-26 9:29 ` Christophe Lyon
@ 2014-05-28 7:26 ` Thomas Schwinge
2014-05-28 21:55 ` Jan Hubicka
1 sibling, 1 reply; 10+ messages in thread
From: Thomas Schwinge @ 2014-05-28 7:26 UTC (permalink / raw)
To: Andrew Pinski, Dominique Dhumieres, Jan Hubicka
Cc: GCC Patches, Richard Guenther
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
Hi!
On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
> On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
> >
> > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
GNU extension).
> strnlen should be declared in include/libiberty.h if there is no
> declaration as libiberty support is already there. That should be a
> simple fix.
Like this?
--- gcc/config.in
+++ gcc/config.in
[Regenerate.]
--- gcc/configure
+++ gcc/configure
[Regenerate.]
--- gcc/configure.ac
+++ gcc/configure.ac
@@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
saved_CXXFLAGS="$CXXFLAGS"
CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
- strsignal strstr stpcpy strverscmp \
+ stpcpy strnlen strsignal strstr strverscmp \
errno snprintf vsnprintf vasprintf malloc realloc calloc \
free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
#include "ansidecl.h"
diff --git include/libiberty.h include/libiberty.h
index 7fd0703..56b8b43 100644
--- include/libiberty.h
+++ include/libiberty.h
@@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
#endif
+#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
+extern size_t strnlen (const char *, size_t);
+#endif
+
#if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
/* Compare version strings. */
extern int strverscmp (const char *, const char *);
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-05-28 7:26 ` Thomas Schwinge
@ 2014-05-28 21:55 ` Jan Hubicka
2014-06-03 9:56 ` Thomas Schwinge
0 siblings, 1 reply; 10+ messages in thread
From: Jan Hubicka @ 2014-05-28 21:55 UTC (permalink / raw)
To: Thomas Schwinge
Cc: Andrew Pinski, Dominique Dhumieres, Jan Hubicka, GCC Patches,
Richard Guenther
> Hi!
>
> On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
> > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
> > >
> > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
>
> I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
> GNU extension).
>
> > strnlen should be declared in include/libiberty.h if there is no
> > declaration as libiberty support is already there. That should be a
> > simple fix.
>
> Like this?
This looks good to me (thoguh strnlen is posix). I can not approve the patch
but I would preffer it over just hand implementing strnlen there (that is easy,
too)
Honza
>
> --- gcc/config.in
> +++ gcc/config.in
> [Regenerate.]
> --- gcc/configure
> +++ gcc/configure
> [Regenerate.]
> --- gcc/configure.ac
> +++ gcc/configure.ac
> @@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> saved_CXXFLAGS="$CXXFLAGS"
> CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
> - strsignal strstr stpcpy strverscmp \
> + stpcpy strnlen strsignal strstr strverscmp \
> errno snprintf vsnprintf vasprintf malloc realloc calloc \
> free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
> #include "ansidecl.h"
> diff --git include/libiberty.h include/libiberty.h
> index 7fd0703..56b8b43 100644
> --- include/libiberty.h
> +++ include/libiberty.h
> @@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
> extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
> #endif
>
> +#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
> +extern size_t strnlen (const char *, size_t);
> +#endif
> +
> #if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
> /* Compare version strings. */
> extern int strverscmp (const char *, const char *);
>
>
> GrĂźĂŸe,
> Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-05-28 21:55 ` Jan Hubicka
@ 2014-06-03 9:56 ` Thomas Schwinge
2014-06-10 6:48 ` Commit policy? " Thomas Schwinge
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Schwinge @ 2014-06-03 9:56 UTC (permalink / raw)
To: Dominique Dhumieres, Jan Hubicka, GCC Patches
Cc: Andrew Pinski, Richard Guenther, Jan Hubicka
[-- Attachment #1: Type: text/plain, Size: 2422 bytes --]
Hi!
Ping -- OK to commit to trunk?
On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka <hubicka@ucw.cz> wrote:
> > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
> > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> > > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
> > > >
> > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
> >
> > I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
> > GNU extension).
> >
> > > strnlen should be declared in include/libiberty.h if there is no
> > > declaration as libiberty support is already there. That should be a
> > > simple fix.
> >
> > Like this?
>
> This looks good to me (thoguh strnlen is posix). I can not approve the patch
> but I would preffer it over just hand implementing strnlen there (that is easy,
> too)
Patch is also considered good by testers in
<https://gcc.gnu.org/PR61334>.
> > --- gcc/config.in
> > +++ gcc/config.in
> > [Regenerate.]
> > --- gcc/configure
> > +++ gcc/configure
> > [Regenerate.]
> > --- gcc/configure.ac
> > +++ gcc/configure.ac
> > @@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> > saved_CXXFLAGS="$CXXFLAGS"
> > CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> > gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
> > - strsignal strstr stpcpy strverscmp \
> > + stpcpy strnlen strsignal strstr strverscmp \
> > errno snprintf vsnprintf vasprintf malloc realloc calloc \
> > free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
> > #include "ansidecl.h"
> > diff --git include/libiberty.h include/libiberty.h
> > index 7fd0703..56b8b43 100644
> > --- include/libiberty.h
> > +++ include/libiberty.h
> > @@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
> > extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
> > #endif
> >
> > +#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
> > +extern size_t strnlen (const char *, size_t);
> > +#endif
> > +
> > #if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
> > /* Compare version strings. */
> > extern int strverscmp (const char *, const char *);
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-06-03 9:56 ` Thomas Schwinge
@ 2014-06-10 6:48 ` Thomas Schwinge
2014-06-10 6:54 ` Andrew Pinski
2014-06-10 9:07 ` Richard Biener
0 siblings, 2 replies; 10+ messages in thread
From: Thomas Schwinge @ 2014-06-10 6:48 UTC (permalink / raw)
To: GCC Patches
Cc: Dominique Dhumieres, Jan Hubicka, Andrew Pinski,
Richard Guenther, Jan Hubicka, dave.anglin, ro, iains
[-- Attachment #1: Type: text/plain, Size: 2941 bytes --]
Hi!
On Tue, 3 Jun 2014 11:55:44 +0200, I wrote:
> Ping -- OK to commit to trunk?
Even though several of those who I'd consider regular GCC developers do
agree with this patch (see also <https://gcc.gnu.org/PR61334>), that is
not enough "consensus" to consider this patch approved, right? Wouldn't
it be a good idea for GCC to move to a more "liberal" policy in this
regard? (That seems to work nicely for glibc.)
Ping.
> On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka <hubicka@ucw.cz> wrote:
> > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
> > > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> > > > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
> > > > >
> > > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
> > >
> > > I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
> > > GNU extension).
> > >
> > > > strnlen should be declared in include/libiberty.h if there is no
> > > > declaration as libiberty support is already there. That should be a
> > > > simple fix.
> > >
> > > Like this?
> >
> > This looks good to me (thoguh strnlen is posix). I can not approve the patch
> > but I would preffer it over just hand implementing strnlen there (that is easy,
> > too)
>
> Patch is also considered good by testers in
> <https://gcc.gnu.org/PR61334>.
>
> > > --- gcc/config.in
> > > +++ gcc/config.in
> > > [Regenerate.]
> > > --- gcc/configure
> > > +++ gcc/configure
> > > [Regenerate.]
> > > --- gcc/configure.ac
> > > +++ gcc/configure.ac
> > > @@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> > > saved_CXXFLAGS="$CXXFLAGS"
> > > CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> > > gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
> > > - strsignal strstr stpcpy strverscmp \
> > > + stpcpy strnlen strsignal strstr strverscmp \
> > > errno snprintf vsnprintf vasprintf malloc realloc calloc \
> > > free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
> > > #include "ansidecl.h"
> > > diff --git include/libiberty.h include/libiberty.h
> > > index 7fd0703..56b8b43 100644
> > > --- include/libiberty.h
> > > +++ include/libiberty.h
> > > @@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
> > > extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
> > > #endif
> > >
> > > +#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
> > > +extern size_t strnlen (const char *, size_t);
> > > +#endif
> > > +
> > > #if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
> > > /* Compare version strings. */
> > > extern int strverscmp (const char *, const char *);
>
>
> Grüße,
> Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-06-10 6:48 ` Commit policy? " Thomas Schwinge
@ 2014-06-10 6:54 ` Andrew Pinski
2014-06-10 9:07 ` Richard Biener
1 sibling, 0 replies; 10+ messages in thread
From: Andrew Pinski @ 2014-06-10 6:54 UTC (permalink / raw)
To: Thomas Schwinge
Cc: GCC Patches, Dominique Dhumieres, Jan Hubicka, Richard Guenther,
dave.anglin, ro, iains
On Mon, Jun 9, 2014 at 11:47 PM, Thomas Schwinge
<thomas@codesourcery.com> wrote:
> Hi!
>
> On Tue, 3 Jun 2014 11:55:44 +0200, I wrote:
>> Ping -- OK to commit to trunk?
>
> Even though several of those who I'd consider regular GCC developers do
> agree with this patch (see also <https://gcc.gnu.org/PR61334>), that is
> not enough "consensus" to consider this patch approved, right? Wouldn't
> it be a good idea for GCC to move to a more "liberal" policy in this
> regard? (That seems to work nicely for glibc.)
Really I think this is an obvious patch and would be the exact same
patch I would have came up with.
Thanks,
Andrew Pinski
>
>
> Ping.
>
>
>> On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka <hubicka@ucw.cz> wrote:
>> > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
>> > > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>> > > > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
>> > > > >
>> > > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
>> > >
>> > > I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
>> > > GNU extension).
>> > >
>> > > > strnlen should be declared in include/libiberty.h if there is no
>> > > > declaration as libiberty support is already there. That should be a
>> > > > simple fix.
>> > >
>> > > Like this?
>> >
>> > This looks good to me (thoguh strnlen is posix). I can not approve the patch
>> > but I would preffer it over just hand implementing strnlen there (that is easy,
>> > too)
>>
>> Patch is also considered good by testers in
>> <https://gcc.gnu.org/PR61334>.
>>
>> > > --- gcc/config.in
>> > > +++ gcc/config.in
>> > > [Regenerate.]
>> > > --- gcc/configure
>> > > +++ gcc/configure
>> > > [Regenerate.]
>> > > --- gcc/configure.ac
>> > > +++ gcc/configure.ac
>> > > @@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
>> > > saved_CXXFLAGS="$CXXFLAGS"
>> > > CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
>> > > gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
>> > > - strsignal strstr stpcpy strverscmp \
>> > > + stpcpy strnlen strsignal strstr strverscmp \
>> > > errno snprintf vsnprintf vasprintf malloc realloc calloc \
>> > > free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
>> > > #include "ansidecl.h"
>> > > diff --git include/libiberty.h include/libiberty.h
>> > > index 7fd0703..56b8b43 100644
>> > > --- include/libiberty.h
>> > > +++ include/libiberty.h
>> > > @@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
>> > > extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
>> > > #endif
>> > >
>> > > +#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
>> > > +extern size_t strnlen (const char *, size_t);
>> > > +#endif
>> > > +
>> > > #if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
>> > > /* Compare version strings. */
>> > > extern int strverscmp (const char *, const char *);
>>
>>
>> Grüße,
>> Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
2014-06-10 6:48 ` Commit policy? " Thomas Schwinge
2014-06-10 6:54 ` Andrew Pinski
@ 2014-06-10 9:07 ` Richard Biener
1 sibling, 0 replies; 10+ messages in thread
From: Richard Biener @ 2014-06-10 9:07 UTC (permalink / raw)
To: Thomas Schwinge
Cc: GCC Patches, Dominique Dhumieres, Jan Hubicka, Andrew Pinski,
dave.anglin, ro, iains
On Tue, Jun 10, 2014 at 8:47 AM, Thomas Schwinge
<thomas@codesourcery.com> wrote:
> Hi!
>
> On Tue, 3 Jun 2014 11:55:44 +0200, I wrote:
>> Ping -- OK to commit to trunk?
>
> Even though several of those who I'd consider regular GCC developers do
> agree with this patch (see also <https://gcc.gnu.org/PR61334>), that is
> not enough "consensus" to consider this patch approved, right? Wouldn't
> it be a good idea for GCC to move to a more "liberal" policy in this
> regard? (That seems to work nicely for glibc.)
Ok.
Thanks,
Richard.
>
> Ping.
>
>
>> On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka <hubicka@ucw.cz> wrote:
>> > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
>> > > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>> > > > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
>> > > > >
>> > > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
>> > >
>> > > I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
>> > > GNU extension).
>> > >
>> > > > strnlen should be declared in include/libiberty.h if there is no
>> > > > declaration as libiberty support is already there. That should be a
>> > > > simple fix.
>> > >
>> > > Like this?
>> >
>> > This looks good to me (thoguh strnlen is posix). I can not approve the patch
>> > but I would preffer it over just hand implementing strnlen there (that is easy,
>> > too)
>>
>> Patch is also considered good by testers in
>> <https://gcc.gnu.org/PR61334>.
>>
>> > > --- gcc/config.in
>> > > +++ gcc/config.in
>> > > [Regenerate.]
>> > > --- gcc/configure
>> > > +++ gcc/configure
>> > > [Regenerate.]
>> > > --- gcc/configure.ac
>> > > +++ gcc/configure.ac
>> > > @@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
>> > > saved_CXXFLAGS="$CXXFLAGS"
>> > > CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
>> > > gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
>> > > - strsignal strstr stpcpy strverscmp \
>> > > + stpcpy strnlen strsignal strstr strverscmp \
>> > > errno snprintf vsnprintf vasprintf malloc realloc calloc \
>> > > free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
>> > > #include "ansidecl.h"
>> > > diff --git include/libiberty.h include/libiberty.h
>> > > index 7fd0703..56b8b43 100644
>> > > --- include/libiberty.h
>> > > +++ include/libiberty.h
>> > > @@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
>> > > extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
>> > > #endif
>> > >
>> > > +#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
>> > > +extern size_t strnlen (const char *, size_t);
>> > > +#endif
>> > > +
>> > > #if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
>> > > /* Compare version strings. */
>> > > extern int strverscmp (const char *, const char *);
>>
>>
>> Grüße,
>> Thomas
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-06-10 9:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-26 9:00 [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags Dominique Dhumieres
2014-05-26 9:16 ` Andrew Pinski
2014-05-26 9:29 ` Christophe Lyon
2014-05-26 16:32 ` Jan Hubicka
2014-05-28 7:26 ` Thomas Schwinge
2014-05-28 21:55 ` Jan Hubicka
2014-06-03 9:56 ` Thomas Schwinge
2014-06-10 6:48 ` Commit policy? " Thomas Schwinge
2014-06-10 6:54 ` Andrew Pinski
2014-06-10 9:07 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).