From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-376626-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 24630 invoked by alias); 2 Sep 2014 08:43:33 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 24468 invoked by uid 89); 2 Sep 2014 08:43:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-wg0-f43.google.com
Received: from mail-wg0-f43.google.com (HELO mail-wg0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 02 Sep 2014 08:43:30 +0000
Received: by mail-wg0-f43.google.com with SMTP id a1so6417991wgh.2        for <gcc-patches@gcc.gnu.org>; Tue, 02 Sep 2014 01:43:27 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.180.106.6 with SMTP id gq6mr27639008wib.5.1409647407307; Tue, 02 Sep 2014 01:43:27 -0700 (PDT)
Received: by 10.194.20.69 with HTTP; Tue, 2 Sep 2014 01:43:27 -0700 (PDT)
In-Reply-To: <CABu31nO=TQKLatDFRvJBZo_JfCMstSzxm=_PGiig97fQqkHUxQ@mail.gmail.com>
References: <1409641427-29875-1-git-send-email-andi@firstfloor.org>	<CA+=Sn1nJAiKUOZB_QA4D_VHKAH6KiW9aNP2rJPCdJqTOvFZzFA@mail.gmail.com>	<20140902072019.GX4120@two.firstfloor.org>	<CA+=Sn1kCQrAysb7zA6Oka5eCAkwrfgZeps65opntNE-e1V+dng@mail.gmail.com>	<CABu31nO=TQKLatDFRvJBZo_JfCMstSzxm=_PGiig97fQqkHUxQ@mail.gmail.com>
Date: Tue, 02 Sep 2014 08:43:00 -0000
Message-ID: <CAFiYyc0XzKwgkbf+S=3a4sMa7HrO5tbngqaFUrUVz8v7+vatMQ@mail.gmail.com>
Subject: Re: [PATCH] Force rtl templates to be inlined
From: Richard Biener <richard.guenther@gmail.com>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>, Andi Kleen <andi@firstfloor.org>, 	GCC Patches <gcc-patches@gcc.gnu.org>, Andi Kleen <ak@linux.intel.com>, 	David Malcolm <dmalcolm@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-09/txt/msg00107.txt.bz2

On Tue, Sep 2, 2014 at 10:36 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Tue, Sep 2, 2014 at 9:22 AM, Andrew Pinski wrote:
>> On Tue, Sep 2, 2014 at 12:20 AM, Andi Kleen wrote:
>>>
>>>> there have been bugs in the past in the area of always_inline too.
>>>
>>> You're arguing for my patch. It would find those bugs.
>>
>>
>> No I am arguing against it since the older versions of GCC we cannot change.
>
> Should such bugs turn up, we can account for them in ansidecl.h.
>
> I think Andi's patch should go in.

I disagree.  always-inline isn't an optimization attribute but a correctness
one.

Instead we should not build stage1 with -O0 if we detect a reasonably
recent GCC host compiler (say one that is still maintained).  Or
we simply should make -finline work at -O0 (I suppose it might already
work?) and use it.

Richard.

> Ciao!
> Steven