* Fix use of availability in ipa-icf
@ 2015-10-08 23:21 Jan Hubicka
2015-10-09 9:33 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jan Hubicka @ 2015-10-08 23:21 UTC (permalink / raw)
To: gcc-patches
Hi,
this is a bug I noticed while reading the code. We can not assume interposable
objects to be equivalent unless they are actually the same symbols.
Bootstrapped/regtested x86_64-linux, comitted.
Honza
* ipa-icf.c (sem_item::compare_symbol_references): Fix use
of availability.
Index: ipa-icf.c
===================================================================
--- ipa-icf.c (revision 228625)
+++ ipa-icf.c (working copy)
@@ -521,8 +521,8 @@ sem_item::compare_symbol_references (
n1 = n1->ultimate_alias_target (&avail1);
n2 = n2->ultimate_alias_target (&avail2);
- if (avail1 >= AVAIL_INTERPOSABLE && ignored_nodes.get (n1)
- && avail2 >= AVAIL_INTERPOSABLE && ignored_nodes.get (n2))
+ if (avail1 > AVAIL_INTERPOSABLE && ignored_nodes.get (n1)
+ && avail2 > AVAIL_INTERPOSABLE && ignored_nodes.get (n2))
return true;
return return_false_with_msg ("different references");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix use of availability in ipa-icf
2015-10-08 23:21 Fix use of availability in ipa-icf Jan Hubicka
@ 2015-10-09 9:33 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2015-10-09 9:33 UTC (permalink / raw)
To: Jan Hubicka; +Cc: GCC Patches
On Fri, Oct 9, 2015 at 1:21 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> this is a bug I noticed while reading the code. We can not assume interposable
> objects to be equivalent unless they are actually the same symbols.
>
> Bootstrapped/regtested x86_64-linux, comitted.
Backport?
> Honza
>
> * ipa-icf.c (sem_item::compare_symbol_references): Fix use
> of availability.
> Index: ipa-icf.c
> ===================================================================
> --- ipa-icf.c (revision 228625)
> +++ ipa-icf.c (working copy)
> @@ -521,8 +521,8 @@ sem_item::compare_symbol_references (
> n1 = n1->ultimate_alias_target (&avail1);
> n2 = n2->ultimate_alias_target (&avail2);
>
> - if (avail1 >= AVAIL_INTERPOSABLE && ignored_nodes.get (n1)
> - && avail2 >= AVAIL_INTERPOSABLE && ignored_nodes.get (n2))
> + if (avail1 > AVAIL_INTERPOSABLE && ignored_nodes.get (n1)
> + && avail2 > AVAIL_INTERPOSABLE && ignored_nodes.get (n2))
> return true;
>
> return return_false_with_msg ("different references");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-09 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-08 23:21 Fix use of availability in ipa-icf Jan Hubicka
2015-10-09 9:33 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).