From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 03FF43858D28 for ; Wed, 3 May 2023 06:16:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03FF43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f004943558so5574014e87.3 for ; Tue, 02 May 2023 23:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683094577; x=1685686577; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mjVayZOMr9+PsuvkHNvGyjm5V5G/HZ6pBcBlv9pF8nM=; b=RGY5EtzxJT8tXbVHImqkDsCwDsRIsYIYyWdlQuOoCF8W9dtefTsCE8X6C/hFBHbo8C HxrWUuO55TuFbLi0w3crP2wy4PDA00QfuV4rFXUOFc/d2zn1K0rGSPugw66T0OwfDE6z WMtMC+NlfwIeoFBWVxgxWqD4rx/UXCsepjs5uAh5f55SauM4xI5zbJEB6M20ddcy0UYJ jOGg1Inho6wL08Z887tE9kTrpxmDVCWtRCzsHe7ytRh5Uqy6ncNI8MoVktef3OEvaQJ5 ARDM+sgZin+kIsEyo9PSG3uaOgB2W+usIxYy1QwKBiIziZHguZukF3UeTeOUj6BVF4XL 9cFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683094577; x=1685686577; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mjVayZOMr9+PsuvkHNvGyjm5V5G/HZ6pBcBlv9pF8nM=; b=YnloRo+tI2z3OKVXlEVMtGvpXdrCFbsHGW9oTbeHDz4abetGCIp2Fx9jEYZ38FP5DZ ni1bWVlRKWQINadJOagDH0/IcmvbR49KOhAttsV/gsmBzXUdytTrxQ67OoVplxxnPEoZ xthcD8dN/lDK1gqgVas29VXC+n5lmjCOCaDVFGDSVWVCqL+2HxIRCRbMPkkVS8VlD9nf yj6/sKEJb9TgG4hPXb5k2r1PZHu8p7zMaWcmkI53ZsWFPgk9vnra04nbckTud89hJTec 0vQFcDkfHO5qGqxmPIotoxDVjHwxAJrouJXqchoNOjPsv7kBUFuYIvPDQsiY0DblDzUg EFtg== X-Gm-Message-State: AC+VfDyrE0t2Mud6k2IIdoweVDHJzqyTERqVMZ+qF/o7CYiE2l5oizjs pAIh8BWSfnaWF2zBJbG59Cgz2ooMuCfTCHexPopiWSEJ X-Google-Smtp-Source: ACHHUZ5dk59KNLF8MYaVvONfZV92EKk3LQYp8zVqqlUlRKdSztwzCxPFQpP47yfoEGaNlX9nu9+W7ALqZoSZkGdEDyU= X-Received: by 2002:ac2:52a6:0:b0:4ee:d4bd:3475 with SMTP id r6-20020ac252a6000000b004eed4bd3475mr550962lfm.32.1683094577164; Tue, 02 May 2023 23:16:17 -0700 (PDT) MIME-Version: 1.0 References: <20230502231417.872953-1-apinski@marvell.com> In-Reply-To: <20230502231417.872953-1-apinski@marvell.com> From: Richard Biener Date: Wed, 3 May 2023 08:16:04 +0200 Message-ID: Subject: Re: [PATCH] Add stats to simple_dce_from_worklist To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 3, 2023 at 1:15=E2=80=AFAM Andrew Pinski via Gcc-patches wrote: > > While looking to move substitute_and_fold_engine > over to use simple_dce_from_worklist, I noticed > that we don't record the stats of the removed stmts/phis. > So this does that. > > OK? Bootstrapped and tested on x86_64-linux-gnu. > > gcc/ChangeLog: > > * tree-ssa-dce.cc (simple_dce_from_worklist): Record > stats on removed number of statements and phis. > --- > gcc/tree-ssa-dce.cc | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/gcc/tree-ssa-dce.cc b/gcc/tree-ssa-dce.cc > index 1fd88e8ee37..86a33e1a40d 100644 > --- a/gcc/tree-ssa-dce.cc > +++ b/gcc/tree-ssa-dce.cc > @@ -2099,6 +2099,8 @@ make_pass_cd_dce (gcc::context *ctxt) > void > simple_dce_from_worklist (bitmap worklist) > { > + long phiremoved =3D 0; > + long stmtremoved =3D 0; The statistics API takes an 'int', OK with changing these accordingly. > while (! bitmap_empty_p (worklist)) > { > /* Pop item. */ > @@ -2144,12 +2146,20 @@ simple_dce_from_worklist (bitmap worklist) > } > gimple_stmt_iterator gsi =3D gsi_for_stmt (t); > if (gimple_code (t) =3D=3D GIMPLE_PHI) > - remove_phi_node (&gsi, true); > + { > + remove_phi_node (&gsi, true); > + phiremoved++; > + } > else > { > unlink_stmt_vdef (t); > gsi_remove (&gsi, true); > release_defs (t); > + stmtremoved++; > } > } > + statistics_counter_event (cfun, "PHIs removed", > + phiremoved); > + statistics_counter_event (cfun, "Statements removed", > + stmtremoved); > } > -- > 2.39.1 >