From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, alan.lawrence@arm.com
Subject: Re: [patch] Fix PR tree-optimization/70884
Date: Mon, 09 May 2016 10:02:00 -0000 [thread overview]
Message-ID: <CAFiYyc0bLjfH4c2r1xXJDqKQm43WA1kKeBQHUBdGgDA8qoREqQ@mail.gmail.com> (raw)
In-Reply-To: <6226269.FBBDIS7nhY@polaris>
On Sat, May 7, 2016 at 11:22 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> Hi,
>
> this is a tentative fix for the regression introduced in SRA by the machinery
> which deals with the constant pool. initialize_constant_pool_replacements is
> supposed to issues new loads from the pool for scalarized variables, but it
> fails to do so for variables that are only partially scalarized.
>
> Tested on PowerPC/Linux and x86-64/Linux, OK for mainline and 6 branch?
Hmm, the patch looks obvious if it was the intent to allow constant
pool replacements
_not_ only when the whole constant pool entry may go away. But I
think the intent was
to not do this otherwise it will generate worse code by forcing all
loads from the constant pool to appear at
function start.
So - the "real" issue may be a missing
should_scalarize_away_bitmap/cannot_scalarize_away_bitmap
check somewhere.
Alan?
Thanks,
Richrd.
>
> 2016-05-07 Eric Botcazou <ebotcazou@adacore.com>
>
> PR tree-optimization/70884
> * tree-sra.c (initialize_constant_pool_replacements): Process all the
> candidate variables.
>
>
> 2016-05-07 Eric Botcazou <ebotcazou@adacore.com>
>
> * gcc.dg/pr70884.c: New test.
>
> --
> Eric Botcazou
next prev parent reply other threads:[~2016-05-09 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 21:22 Eric Botcazou
2016-05-09 10:02 ` Richard Biener [this message]
2016-05-13 11:01 ` Eric Botcazou
2016-05-13 11:52 ` Richard Biener
2016-05-13 15:24 ` Martin Jambor
2016-05-20 7:34 ` Eric Botcazou
2016-05-20 9:32 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc0bLjfH4c2r1xXJDqKQm43WA1kKeBQHUBdGgDA8qoREqQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=alan.lawrence@arm.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).