From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uc+a=4A=gmail.com=richard.guenther@sourceware.org>
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129])
	by sourceware.org (Postfix) with ESMTPS id 20E713858D35
	for <gcc-patches@gcc.gnu.org>; Fri,  2 Dec 2022 07:48:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20E713858D35
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-lf1-x129.google.com with SMTP id c1so6191486lfi.7
        for <gcc-patches@gcc.gnu.org>; Thu, 01 Dec 2022 23:48:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=vS96EXXIHXzAkJlDeXoyL2vdbCcnNhiwJmvx/cgJPRM=;
        b=cIRKuwknnHziWpjktu+H7nqSsbWJJ/Pf0YykUBE4g7sRsHyV4dZuv3Xy4nGuwjjENy
         gPKk51XnFj8wDPyIV4T6X7Fb5yGu3YiRMQUG6TLVrvjyoBr7tLGla2ReWzACFREFgGWI
         qXYtnLtjGn7cpYWl4ElRjeR4amBQILSqd/jkulgPuTT2GzNIcGLhYng2G8PrSb8Wv4Fw
         XLhHnxXiM9RGaRJ6WXk6fdx9vEmqiv0ap+UxHIv96upeucKGNw5OlIOjBa2PGluIaYe6
         YF95GBwVxvgMz+vzO6HHLwsgMg6EeNE8YMWiLHfmsjNwRP/768czr4bMYUlDYNojlrCM
         slnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=vS96EXXIHXzAkJlDeXoyL2vdbCcnNhiwJmvx/cgJPRM=;
        b=dCIDP+upMzmoBGWlRscHo68LTVjRJoCCoNBMjp8IoRoa6YEsxU5HkNabLV5Z2oDf2g
         2JqpXr9JKfOUG8G4caWeEJ2pvdAIskcor1VWpJN4NsMysIdHOR2EqBligqFD1JxmCq99
         mJKsSd+RPBt2BDx+nlNHWKkxsjFSk4uZGKMBVXkoAT3cx7zP2SWP2kMz3018zS0j/FeH
         N3qdCPOrjfR7oCMV0UXonbCLUtWeTZRrwsw73P7+fCcDNs3aP9mFYCHIxL7/XPPH6XEV
         Ss33d7dHUXqdUsJElRloc9YyLmTQtKP61SjrC6QzmlkgaLdGGHhZFl6jkTdYcXHFRTgc
         6hZA==
X-Gm-Message-State: ANoB5pmYsJgvwkZFdhamOpOZ0VBnk7REYtxwlJZ0oGCkRz7xDMCGzSCZ
	qqQbvflTXOIPPaEu++JhETToTUPnFS5KsJ7TGAiSoWtdeDs=
X-Google-Smtp-Source: AA0mqf6BDFMqaYNGgSmSqTL+tFBAmpFcIb60VNVPVuxcmeAJ3ZswTS01YazU4zOZy8pffLqeKLuassKAabAqeaPjffw=
X-Received: by 2002:ac2:4c42:0:b0:4a5:bf09:a700 with SMTP id
 o2-20020ac24c42000000b004a5bf09a700mr16650704lfk.656.1669967293708; Thu, 01
 Dec 2022 23:48:13 -0800 (PST)
MIME-Version: 1.0
References: <CAEYL+X_ta9=7wKrWZT7TArBiOi79S2WzTtsqOwueUf8Vm2cjvw@mail.gmail.com>
 <8FF347A1-0569-4A57-B0AE-9760A70AA010@gmail.com> <CAEYL+X9rNbOHanPNrYmtGHXMD2NhCWRiyTXkzG=YxOPRZBAUvA@mail.gmail.com>
 <CA+=Sn1njXotzb_bkfZOOhd9MDUEqvLwLS2KCVyFsQ4thWwZTtA@mail.gmail.com>
 <CAEYL+X_dJfJ4gRjUgKnx3TdaqZEWSRV+GBvS4jYeO4Tntya9tg@mail.gmail.com>
 <CAFiYyc0b9YXc4smF9Vkzqb2qVBiM2DWCnTRj7P6FYy5RHYhq4Q@mail.gmail.com>
 <CAEYL+X9mQNwWUr1k8g2LTxG3_NfgMFa-fz3NMcVNeMqARpSv1w@mail.gmail.com> <CAFiYyc1=y7iy-RpBsq301R_72kAeY=En4sUrWTLHqxULTz0fQA@mail.gmail.com>
In-Reply-To: <CAFiYyc1=y7iy-RpBsq301R_72kAeY=En4sUrWTLHqxULTz0fQA@mail.gmail.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 2 Dec 2022 08:48:01 +0100
Message-ID: <CAFiYyc0cLi33mo9MWFSxh6zXD4iU7=gzUH++cD8GUrsQ7iNpFA@mail.gmail.com>
Subject: Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)
To: Zopolis0 <creatorsmithmdt@gmail.com>
Cc: Andrew Pinski <pinskia@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Fri, Dec 2, 2022 at 8:43 AM Richard Biener
<richard.guenther@gmail.com> wrote:
>
> On Fri, Dec 2, 2022 at 1:23 AM Zopolis0 <creatorsmithmdt@gmail.com> wrote:
> >
> > > But that looks like the correct thing to do.
> >
> > It's not. The patch I reverted changes it so that no matter what,
> > void_list_node = build_tree_list (NULL_TREE, void_type_node);.
> >
> > Before, each front-end set it in their own way, but they all set it
> > via void_list_node = build_tree_list (NULL_TREE, void_type_node); or a
> > synonym anyway. So while the patch made sense in a java-free context,
> > given that java sets it a different way, I can't see a world in which
> > this commit stays active and Java works, unless we find a way to set
> > it in tree.cc for every language except Java.
>
> The middle-end expects it to be this way, it's not correct for a frontend
> to define it in other ways.  That means you need to try to understand
> _why_ the frontend isn't happy with the middle-ends definition.
>
> How does Java build end_params_node?

Looking at the 4.7 tree it does

decl.c:  end_params_node = tree_cons (NULL_TREE, void_type_node, NULL_TREE);

that's exactly the same.

> Richard.