From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128903 invoked by alias); 22 Oct 2015 07:43:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128888 invoked by uid 89); 22 Oct 2015 07:43:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f178.google.com Received: from mail-yk0-f178.google.com (HELO mail-yk0-f178.google.com) (209.85.160.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 22 Oct 2015 07:43:09 +0000 Received: by ykdr3 with SMTP id r3so74554839ykd.1 for ; Thu, 22 Oct 2015 00:43:07 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.13.202.139 with SMTP id m133mr9720432ywd.305.1445499787136; Thu, 22 Oct 2015 00:43:07 -0700 (PDT) Received: by 10.37.117.136 with HTTP; Thu, 22 Oct 2015 00:43:07 -0700 (PDT) In-Reply-To: <5627C764.2000505@redhat.com> References: <1445376433-14658-1-git-send-email-rth@redhat.com> <1445376433-14658-11-git-send-email-rth@redhat.com> <56279514.8020605@redhat.com> <5627C764.2000505@redhat.com> Date: Thu, 22 Oct 2015 07:48:00 -0000 Message-ID: Subject: Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces From: Richard Biener To: Richard Henderson Cc: Jeff Law , GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02197.txt.bz2 On Wed, Oct 21, 2015 at 7:12 PM, Richard Henderson wrote: > On 10/21/2015 03:37 AM, Jeff Law wrote: >> >> On 10/20/2015 03:27 PM, Richard Henderson wrote: >>> >>> --- >>> gcc/cselib.c | 22 >>> +++++++++++++--------- >>> gcc/fold-const.c | 14 +++++++------- >>> gcc/testsuite/gcc.target/i386/addr-space-2.c | 11 +++++++++++ >>> 3 files changed, 31 insertions(+), 16 deletions(-) >>> create mode 100644 gcc/testsuite/gcc.target/i386/addr-space-2.c >> >> This part is fine. Does the one testcase cover both the cselib.c & >> fold-const.c fix? If not, it'd be good to cover both if we can. > > > Yes it does. > > The fold-const fix gets us as far as .optimized, but then the cselib fix > gets us past postreload-cse. These fixes are appropriate for backporting as well I think. Richard. > > r~