From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108897 invoked by alias); 20 Jan 2020 10:25:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108878 invoked by uid 89); 20 Jan 2020 10:25:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=Google, google X-HELO: mail-lf1-f65.google.com Received: from mail-lf1-f65.google.com (HELO mail-lf1-f65.google.com) (209.85.167.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2020 10:25:35 +0000 Received: by mail-lf1-f65.google.com with SMTP id b15so23619446lfc.4 for ; Mon, 20 Jan 2020 02:25:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iB0VEqQNvRRxRiTWlpZX9aGUQsJOlqf9KL9gY5bGwcc=; b=fGZJbRQkW5Bo5qLelnxFSqvlrQ0mZgdUwxJ1SQ5iiAOPl18t1Ncry1vg6ZVzxzwPyv zNsfXnxCz7CpsRdLXql9S1Pj3bOSuqvbX8VHBPqwEkML+I/OlNEAdWIEltXCoaP3Ywbh C5ltZyuHkD1vbIe+ron6mAIWvnJhwPdcLJPjvF03CVVbiug0fqw9SpL7ujnKpa48fRaN KAQTD8MRDXcA/PdwRHXoVhWgxxn+lM1DUF+Uykbrj9495ytc6joSjg5p49H5IMRnrLEV RCXrbXFQpNMtzxd6EyVPwe/z9qBkNidUpWolpRgcTe2EEHGZbwmZkoVyTjWWzCbHY3r+ aEVg== MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 20 Jan 2020 10:34:00 -0000 Message-ID: Subject: Re: [PATCH] Make target_clones resolver fn static. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= , "H. J. Lu" , Uros Bizjak Cc: GCC Patches , Alexander Monakov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg01178.txt.bz2 On Fri, Jan 17, 2020 at 10:25 AM Martin Li=C5=A1ka wrote: > > Hi. > > The patch removes need to have a gnu_indirect_function global > symbol. That aligns the code with what ppc64 target does. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Did you verify the result actually works? I'm not sure we have any runtime= test coverage for the feature and non-public functions and you don't add a testc= ase either. Maybe there's interesting coverage in the binutils or glibc testsu= ite (though both might not use the compilers ifunc feature...). The patch also suspiciously lacks removal of actually making the resolver TREE_PUBLIC if the default implementation was not ... so I wonder whether you verified that the resolver _is_ indeed local. HJ, do you know anything about this requirement? It's that way since the original contribution of multi-versioning by Google... Richard. > Thanks, > Martin > > gcc/ChangeLog: > > 2020-01-17 Martin Liska > > PR target/93274 > * config/i386/i386-features.c (make_resolver_func): > Align the code with ppc64 target implementaion. > We do not need to have gnu_indirect_function > as a global function. > > gcc/testsuite/ChangeLog: > > 2020-01-17 Martin Liska > > PR target/93274 > * gcc.target/i386/pr81213.c: Adjust to not expect > a global unique name. > --- > gcc/config/i386/i386-features.c | 20 +++++--------------- > gcc/testsuite/gcc.target/i386/pr81213.c | 4 ++-- > 2 files changed, 7 insertions(+), 17 deletions(-) > >