From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81889 invoked by alias); 10 Oct 2016 09:54:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 81879 invoked by uid 89); 10 Oct 2016 09:54:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:977 X-HELO: mail-lf0-f68.google.com Received: from mail-lf0-f68.google.com (HELO mail-lf0-f68.google.com) (209.85.215.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Oct 2016 09:53:52 +0000 Received: by mail-lf0-f68.google.com with SMTP id p80so9101647lfp.1 for ; Mon, 10 Oct 2016 02:53:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fVUzDHOQTjCzp4jSJnDvRY8YchC4sXccIzZYC1lyuDw=; b=HeJnjGfleIQ0Bs0lcxCkyl27JjAZ6FyR4A9JDxSIA9cTQFgco6g0LpWDFbdgan3knm lK8dtap4nakf5ilTurnCdrsOkcSKl6sqFy65XpUWfRQTwqtDx/x9wXsYiyaY30Ko9uJA 60b0YtPom5JQvjx1otMQjf1zIOGWo/W9x2njVDKmAbUwfZDnsPgEz+JQPthJf0wXfv2Z fdta4XQcofoMZLNGNCIQOvTd7RDa77YwRXEOiIk1+jWZXtr/Kqy8W4hGlPiK7RI5j3fD fmk18CvWfi+XAg5AUbru+8gytCunrAhrWKQm/RPAewHlNrn8dqc9tDhdespDwrWujlMo 0rPg== X-Gm-Message-State: AA6/9Rk7u4FCkLPzfLuUZsmEyHEXi2q/detFJXZN0Qfil6Bg7aN70/kYK2ihRIgmPqMTiBx4NwHFvny3Wlig0g== X-Received: by 10.194.30.137 with SMTP id s9mr30703802wjh.77.1476093230438; Mon, 10 Oct 2016 02:53:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.155.146 with HTTP; Mon, 10 Oct 2016 02:53:49 -0700 (PDT) In-Reply-To: <2908590d-f799-7053-9f52-2f0b65803c4e@mentor.com> References: <2908590d-f799-7053-9f52-2f0b65803c4e@mentor.com> From: Richard Biener Date: Mon, 10 Oct 2016 09:54:00 -0000 Message-ID: Subject: Re: [PATCH, PR77558] Remove RECORD_TYPE special-casing in std_canonical_va_list_type To: Tom de Vries Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00583.txt.bz2 On Sun, Sep 25, 2016 at 11:08 AM, Tom de Vries wrote: > Hi, > > this patch fixes PR77558, an ice-on-invalid-code 6/7 regression. > > The fix for PR71602 introduced the invalid-code test-case > c-c++-common/va-arg-va-list-type.c: > ... > __builtin_va_list *pap; > > void > fn1 (void) > { > __builtin_va_arg (pap, double); /* { dg-error "first argument to 'va_arg' > not of type 'va_list'" } */ > } > ... > > The test-case passes for x86_64, but fails for aarch64 and ICEs for arm. > > The ICE happens because the patch for PR71602 is incomplete. The patch tries > to be more strict about returning a canonical va_list only for actual > va_lists, but doesn't implement this for structure va_list types, such as we > have for arm, aarch64 and alpha. > > This patch adds the missing part, and fixes the ICE. > > OK for trunk, 6-branch? Ok. Richard. > Thanks, > - Tom