From: Richard Biener <richard.guenther@gmail.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "Koval, Julia" <julia.koval@intel.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [patch][x86] -march=icelake
Date: Tue, 19 Dec 2017 11:55:00 -0000 [thread overview]
Message-ID: <CAFiYyc0f=9R0d9vSXPA+0FVYFf7bhF4JCZnF15-ucsiFjMxt=A@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4anDT-gLMFv_YcH8+D_ZdUa5jZnpuxH4GOskP992UKNXA@mail.gmail.com>
On Tue, Dec 19, 2017 at 9:29 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Mon, Dec 18, 2017 at 2:42 PM, Koval, Julia <julia.koval@intel.com> wrote:
>> Hi, I tried to replace 2 flags variable with c++ bitset(in patch attached). What do you think?
>
> Hm, I'm not a c++ person, but I wonder about overhead and performance
> impact of this change. Maybe [] operator could be used instead of a
> dynamic handling here. Please discuss with a c++ person to find out
> the most appropriate approach.
The natural GCC data structure is a sbitmap ... I'd rather not use <bitset>
given we have a GCC variant.
>>> Please add these options first.
>> 2 options left(they are under Kirill's review currently), I'll add PTAs for them to the patch, as soon as they will be commited.
>
> Actually, let's wait for these 2 options to be reviewed and committed
> first, and after that introduce -march=icelake handling.
>
> Uros.
next prev parent reply other threads:[~2017-12-19 11:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 7:33 Koval, Julia
2017-11-12 16:34 ` Uros Bizjak
2017-12-18 13:42 ` Koval, Julia
2017-12-19 8:31 ` Uros Bizjak
2017-12-19 11:55 ` Richard Biener [this message]
2017-12-19 12:34 ` Koval, Julia
2017-12-19 13:08 ` Richard Biener
2017-12-19 13:49 ` Jakub Jelinek
2018-01-22 11:46 ` Koval, Julia
2018-01-22 12:12 ` Jakub Jelinek
2018-01-22 15:10 ` Koval, Julia
2018-01-24 11:05 ` Uros Bizjak
2018-01-24 11:18 ` Jakub Jelinek
2018-01-24 11:24 ` Koval, Julia
2018-01-24 11:31 ` Richard Biener
2018-01-30 8:53 ` Koval, Julia
2018-01-30 9:56 ` Jakub Jelinek
2018-01-30 12:55 ` Koval, Julia
2018-02-01 7:49 ` Uros Bizjak
2018-02-01 14:02 ` Jakub Jelinek
2017-11-12 17:33 ` Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0f=9R0d9vSXPA+0FVYFf7bhF4JCZnF15-ucsiFjMxt=A@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=julia.koval@intel.com \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).