From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42308 invoked by alias); 2 Aug 2017 12:53:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 39024 invoked by uid 89); 2 Aug 2017 12:53:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f182.google.com Received: from mail-qk0-f182.google.com (HELO mail-qk0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Aug 2017 12:53:47 +0000 Received: by mail-qk0-f182.google.com with SMTP id d145so26130903qkc.2 for ; Wed, 02 Aug 2017 05:53:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MDLEVzuzw+RAnWXYIJrd0Vd5UDil1q0qQqd9B9bQeJI=; b=NjxZk/z7ahBCUud2MNqIWFAu5JzZGbr3QV3T/+plTKPzgsGB01xON0CbM0cKG/9WV1 Vh5vQ4YC2EV1GTUd9fZ0c+cGeuEkWNEsDme4jz7tBQRBodTMVua6432f4v+eZ1vBqA24 o0Nw7++YuJJRaoc2zaxpjCSBxTbuOgTJjt7dcQioceAgrH7SBv9t8XfHq/EIhNN1mMYF 5O8/16lN9AeOGd3sIsdwcgDUw38qq0yY4gHQxXmdzvCXXCS2krQtswghRg7ib8KBYAuy p5/SCHYoy+X5+VPBdw4B9+0zA2YVuLo4s2/EOVR9nEmXFAMWnwyhiGjeCC/jtfYtNG6G a/rA== X-Gm-Message-State: AIVw113ba8PlcDEyqSfOpIwUpNoqC6Fd6CvZasoRXceSPPV4mBp5zZk0 CSxnyrHqgwgNX6svL5DJyJIcoi6omQ== X-Received: by 10.55.18.222 with SMTP id 91mr31047587qks.350.1501678425441; Wed, 02 Aug 2017 05:53:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.43.35 with HTTP; Wed, 2 Aug 2017 05:53:45 -0700 (PDT) In-Reply-To: <20170802124546.GX3397@redhat.com> References: <20170802124546.GX3397@redhat.com> From: Richard Biener Date: Wed, 02 Aug 2017 12:53:00 -0000 Message-ID: Subject: Re: PATCH for base_pool_allocator (PR other/81667) To: Marek Polacek Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00178.txt.bz2 On Wed, Aug 2, 2017 at 2:45 PM, Marek Polacek wrote: > This PR points out that m_elt_size was left uninitialized in the member > initializer list for base_pool_allocator. I think it makes sense to initialize > it like this. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? Ok. Richard. > 2017-08-02 Marek Polacek > > PR other/81667 > * alloc-pool.h (base_pool_allocator): Initialize m_elt_size. > > diff --git gcc/alloc-pool.h gcc/alloc-pool.h > index a5236db3dae..1d04e5d2cfe 100644 > --- gcc/alloc-pool.h > +++ gcc/alloc-pool.h > @@ -240,8 +240,9 @@ base_pool_allocator ::base_pool_allocator ( > const char *name, size_t size MEM_STAT_DECL): > m_name (name), m_id (0), m_elts_per_block (0), m_returned_free_list (NULL), > m_virgin_free_list (NULL), m_virgin_elts_remaining (0), m_elts_allocated (0), > - m_elts_free (0), m_blocks_allocated (0), m_block_list (NULL), m_size (size), > - m_initialized (false), m_location (ALLOC_POOL_ORIGIN, false PASS_MEM_STAT) {} > + m_elts_free (0), m_blocks_allocated (0), m_block_list (NULL), m_elt_size (0), > + m_size (size), m_initialized (false), > + m_location (ALLOC_POOL_ORIGIN, false PASS_MEM_STAT) {} > > /* Initialize a pool allocator. */ > > > Marek