From: Richard Biener <richard.guenther@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jan Hubicka <hubicka@ucw.cz>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types
Date: Fri, 26 Feb 2016 11:13:00 -0000 [thread overview]
Message-ID: <CAFiYyc0ftBdKCFZMe6st-FH=r9o8GXh=JEqXY3mMbUEBfuQtww@mail.gmail.com> (raw)
In-Reply-To: <20160226110458.GA3017@tucnak.redhat.com>
On Fri, Feb 26, 2016 at 12:04 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Feb 26, 2016 at 11:52:50AM +0100, Jan Hubicka wrote:
>> Hi,
>> while looking into the PR testcase I noticed that we detect wrong duplicate
>> types. This is because we compute DECL_ASSEMBLER_NAME of a type variant which
>> is not necessary.
>>
>> Bootstrapped/regested x86_64-linux and I checked dumps of xalancbmk to verify
>> that nothing changes in ODR type merging except for the duplicates. OK?
>>
>> Honza
>> * tree.c (need_assembler_name_p): Do not compute mangled name for
>> variabt types.
>
> s/variabt/variant/
Ok with that fix.
Richard.
> Jakub
prev parent reply other threads:[~2016-02-26 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 10:52 Jan Hubicka
2016-02-26 11:05 ` Jakub Jelinek
2016-02-26 11:13 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0ftBdKCFZMe6st-FH=r9o8GXh=JEqXY3mMbUEBfuQtww@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).