* Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types
@ 2016-02-26 10:52 Jan Hubicka
2016-02-26 11:05 ` Jakub Jelinek
0 siblings, 1 reply; 3+ messages in thread
From: Jan Hubicka @ 2016-02-26 10:52 UTC (permalink / raw)
To: gcc-patches
Hi,
while looking into the PR testcase I noticed that we detect wrong duplicate
types. This is because we compute DECL_ASSEMBLER_NAME of a type variant which
is not necessary.
Bootstrapped/regested x86_64-linux and I checked dumps of xalancbmk to verify
that nothing changes in ODR type merging except for the duplicates. OK?
Honza
* tree.c (need_assembler_name_p): Do not compute mangled name for
variabt types.
Index: tree.c
===================================================================
--- tree.c (revision 233707)
+++ tree.c (working copy)
@@ -5329,6 +5329,7 @@ need_assembler_name_p (tree decl)
&& TREE_CODE (decl) == TYPE_DECL
&& DECL_NAME (decl)
&& decl == TYPE_NAME (TREE_TYPE (decl))
+ && TYPE_MAIN_VARIANT (TREE_TYPE (decl)) == TREE_TYPE (decl)
&& !TYPE_ARTIFICIAL (TREE_TYPE (decl))
&& (type_with_linkage_p (TREE_TYPE (decl))
|| TREE_CODE (TREE_TYPE (decl)) == INTEGER_TYPE)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types
2016-02-26 10:52 Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types Jan Hubicka
@ 2016-02-26 11:05 ` Jakub Jelinek
2016-02-26 11:13 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Jelinek @ 2016-02-26 11:05 UTC (permalink / raw)
To: Jan Hubicka; +Cc: gcc-patches
On Fri, Feb 26, 2016 at 11:52:50AM +0100, Jan Hubicka wrote:
> Hi,
> while looking into the PR testcase I noticed that we detect wrong duplicate
> types. This is because we compute DECL_ASSEMBLER_NAME of a type variant which
> is not necessary.
>
> Bootstrapped/regested x86_64-linux and I checked dumps of xalancbmk to verify
> that nothing changes in ODR type merging except for the duplicates. OK?
>
> Honza
> * tree.c (need_assembler_name_p): Do not compute mangled name for
> variabt types.
s/variabt/variant/
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types
2016-02-26 11:05 ` Jakub Jelinek
@ 2016-02-26 11:13 ` Richard Biener
0 siblings, 0 replies; 3+ messages in thread
From: Richard Biener @ 2016-02-26 11:13 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Jan Hubicka, GCC Patches
On Fri, Feb 26, 2016 at 12:04 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Feb 26, 2016 at 11:52:50AM +0100, Jan Hubicka wrote:
>> Hi,
>> while looking into the PR testcase I noticed that we detect wrong duplicate
>> types. This is because we compute DECL_ASSEMBLER_NAME of a type variant which
>> is not necessary.
>>
>> Bootstrapped/regested x86_64-linux and I checked dumps of xalancbmk to verify
>> that nothing changes in ODR type merging except for the duplicates. OK?
>>
>> Honza
>> * tree.c (need_assembler_name_p): Do not compute mangled name for
>> variabt types.
>
> s/variabt/variant/
Ok with that fix.
Richard.
> Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-26 11:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26 10:52 Avoid redundant DECL_ASSEMBLER_NAME computations for ODR types Jan Hubicka
2016-02-26 11:05 ` Jakub Jelinek
2016-02-26 11:13 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).