From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id D7DEC3858C53 for ; Thu, 23 Nov 2023 14:23:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D7DEC3858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D7DEC3858C53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1036 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700749387; cv=none; b=Ld3ArmX6zpOKcPmPp5Lus0X2CyXSenVlX1TzTBlfv89fTFKnKGxFcHapvB32F2EF0c536DZKCXDYk7lDUv1xbiciG8+OQEgtr9gI69Q2FcKf9FCXxyOw4HVo0Ujy1rYZsaFpqOt0ijDQktiDn1C4KiH1omVpYaB0naxwJjh2+bA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700749387; c=relaxed/simple; bh=hCwQkKD8wx21E+aw6DWx9Cf5n7PZ4A15DLHHYItFgtA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=tJukJ4tPEvYaVAMtqNYcuYdLRXOc1YQYpTjSWdEnJIoeKaYb1bXFW+JV8u8DnwhsckoK82qfGlanab5CJ1NZrfwa8gx4IF3CKQWMFLHneLl+IAnqiblAeoUU5IvRxcVojqD3cXAzpe8HyQ/qscl/06QDsv1J9zHp7YoOkIbhqUM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2851b271e51so678681a91.1 for ; Thu, 23 Nov 2023 06:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700749385; x=1701354185; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3F8V7qwBTHV/KOTJHjQ5fvqu4qy3GTeJi43NNEGVio0=; b=nDEvWE2a6PJkzGgfpr/y1AIiAOzmhe9uj/7ZJaN3emomY5tIIQFCzZ5cZeHrdkJV+p 1K1VNYjkl+sNKms5cFr0U3VY1MwqzMhANNNludvFxYuxOk+h+j60RklpyArGNVvb6XfJ FPABDrYnKnPBTV2LWEzGdCJpTEQiD2jeSv3UqCSrjZIAnWe9pgX4nI+sMGOg9BipLHh6 F51ev5y82BmDWnan+9znJ/tz98WtJfiPm/fFQc7uM5869Ds8paQoFF6JaVr73Vir+SSD n4Ait0fPvY85ugo0TXS0SykWqb+suL4XFUk5KbMQhkXJHgQ1upWmI/w3WYJDlU0k6dmT saWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700749385; x=1701354185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3F8V7qwBTHV/KOTJHjQ5fvqu4qy3GTeJi43NNEGVio0=; b=oksGqDjX3JpO4UT4dUbp+y1sAlz5xP5OLQe9fK2eiWMHpjqVtLs7KcbtH6sWEXJTQy LQQ+BFB6mLnTG/Vanvsmre+8JxOxvpjNCDS6ABLx1GBTykRcP2Jy3aJwB1F4lgTzs4VI d8WTfkBel6FCKY+asBsCKmRuDOrLxGhQb0tqtepXaz+lIijhdjQZm5ntRQ21aMb1lRq8 NOUu2fS0FlGvt2WE6azKOdI9JC+9/G4Aq8Cp8/OqID4Oiwgg4NsVF+RTr7SAJT1sm1UF xAWU5XhK9GOiTKXQudN4kwNOOvq6a4ZHLU1KdqTHe+6rKrYk7LGt++uOEAY87WnIZU37 6Vrg== X-Gm-Message-State: AOJu0YzEggTcVvfBaYXdgal/Rg5FiyyCGcvAHlVlI2bA2WpmbSYcE0YG 1cEe8pQz6ZSfKDnDlXeyd7sInP5cDdvi34NqGKH8ZG/k X-Google-Smtp-Source: AGHT+IEE/RieWfCYyKNssKeM2lDveXg/x69dh+Wsk21DNH86TCzkJbKDFWMGgawqZVOMOhZEk3U+Uls7IpiZcTPCbcw= X-Received: by 2002:a17:90a:3fc7:b0:280:37a0:69d4 with SMTP id u7-20020a17090a3fc700b0028037a069d4mr3863857pjm.19.1700749384652; Thu, 23 Nov 2023 06:23:04 -0800 (PST) MIME-Version: 1.0 References: <20231123134751.25302-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20231123134751.25302-1-sebastian.huber@embedded-brains.de> From: Richard Biener Date: Thu, 23 Nov 2023 15:19:20 +0100 Message-ID: Subject: Re: [PATCH] gcov: No atomic ops for -fprofile-update=single To: Sebastian Huber Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Nov 23, 2023 at 2:47=E2=80=AFPM Sebastian Huber wrote: > > gcc/ChangeLog: > PR tree-optimization/112678 > > * tree-profile.cc (tree_profiling): Do not use atomic operations > for -fprofile-update=3Dsingle. > --- > gcc/tree-profile.cc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/gcc/tree-profile.cc b/gcc/tree-profile.cc > index 1ac0fdb3bc98..9c8fdb8b18f4 100644 > --- a/gcc/tree-profile.cc > +++ b/gcc/tree-profile.cc > @@ -767,6 +767,7 @@ tree_profiling (void) > =3D HAVE_sync_compare_and_swapsi || HAVE_atomic_compare_and_swapsi; > bool have_atomic_8 > =3D HAVE_sync_compare_and_swapdi || HAVE_atomic_compare_and_swapdi; > + bool needs_split =3D gcov_type_size =3D=3D 8 && !have_atomic_8 && have= _atomic_4; > if (!can_support_atomic) > { > if (gcov_type_size =3D=3D 4) > @@ -775,6 +776,9 @@ tree_profiling (void) > can_support_atomic =3D have_atomic_8; > } > > + if (flag_profile_update !=3D PROFILE_UPDATE_SINGLE && needs_split) > + counter_update =3D COUNTER_UPDATE_ATOMIC_PARTIAL; > + I wonder if it's cleaner to set can_support_atomic when we can support it with splitting instead, avoiding a !=3D PROFILE_UPDATE_SINGLE check here? Otherwise looks OK. Richard. > if (flag_profile_update =3D=3D PROFILE_UPDATE_ATOMIC > && !can_support_atomic) > { > @@ -788,13 +792,11 @@ tree_profiling (void) > > if (flag_profile_update =3D=3D PROFILE_UPDATE_ATOMIC) > { > - if (gcov_type_size =3D=3D 8 && !have_atomic_8 && have_atomic_4) > + if (needs_split) > counter_update =3D COUNTER_UPDATE_ATOMIC_SPLIT; > else > counter_update =3D COUNTER_UPDATE_ATOMIC_BUILTIN; > } > - else if (gcov_type_size =3D=3D 8 && have_atomic_4) > - counter_update =3D COUNTER_UPDATE_ATOMIC_PARTIAL; > > /* This is a small-ipa pass that gets called only once, from > cgraphunit.cc:ipa_passes(). */ > -- > 2.35.3 >