* [Testsuite, committed] Fix vector peeling test failures
@ 2017-05-08 12:51 Wilco Dijkstra
2017-05-08 14:31 ` Richard Biener via gcc-patches
0 siblings, 1 reply; 4+ messages in thread
From: Wilco Dijkstra @ 2017-05-08 12:51 UTC (permalink / raw)
To: GCC Patches; +Cc: nd, Christophe Lyon, Richard Biener
This fixes a few failures on ARM and AArch64 due to a recent change in
alignment peeling by switching the vector cost model off
(https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
Tested on AArch64, ARM and x64 - committed as obvious.
ChangeLog:
2017-05-08 Wilco Dijkstra <wdijkstr@arm.com>
* testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
* gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
--
diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-44.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
@@ -1,4 +1,5 @@
/* { dg-require-effective-target vect_float } */
+/* { dg-options "-fno-vect-cost-model" } */
#include <stdarg.h>
#include "tree-vect.h"
diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-50.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
@@ -1,4 +1,5 @@
/* { dg-require-effective-target vect_float } */
+/* { dg-options "-fno-vect-cost-model" } */
#include <stdarg.h>
#include "tree-vect.h"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Testsuite, committed] Fix vector peeling test failures
2017-05-08 12:51 [Testsuite, committed] Fix vector peeling test failures Wilco Dijkstra
@ 2017-05-08 14:31 ` Richard Biener via gcc-patches
2017-05-09 8:07 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Richard Biener via gcc-patches @ 2017-05-08 14:31 UTC (permalink / raw)
To: Wilco Dijkstra; +Cc: GCC Patches, nd, Christophe Lyon
On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> This fixes a few failures on ARM and AArch64 due to a recent change in
> alignment peeling by switching the vector cost model off
> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
>
> Tested on AArch64, ARM and x64 - committed as obvious.
Thanks. Note that I'm not sure what -fno-vect-cost-model actually means when
peeling for alignment, so this fix might not "prevail".
Richard.
> ChangeLog:
> 2017-05-08 Wilco Dijkstra <wdijkstr@arm.com>
>
> * testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
> * gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
> --
>
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
> index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-44.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
> @@ -1,4 +1,5 @@
> /* { dg-require-effective-target vect_float } */
> +/* { dg-options "-fno-vect-cost-model" } */
>
> #include <stdarg.h>
> #include "tree-vect.h"
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
> index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-50.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
> @@ -1,4 +1,5 @@
> /* { dg-require-effective-target vect_float } */
> +/* { dg-options "-fno-vect-cost-model" } */
>
> #include <stdarg.h>
> #include "tree-vect.h"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Testsuite, committed] Fix vector peeling test failures
2017-05-08 14:31 ` Richard Biener via gcc-patches
@ 2017-05-09 8:07 ` Richard Biener
2017-05-09 8:13 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Richard Biener @ 2017-05-09 8:07 UTC (permalink / raw)
To: Wilco Dijkstra; +Cc: GCC Patches, nd, Christophe Lyon
On Mon, May 8, 2017 at 3:49 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>> This fixes a few failures on ARM and AArch64 due to a recent change in
>> alignment peeling by switching the vector cost model off
>> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
>>
>> Tested on AArch64, ARM and x64 - committed as obvious.
>
> Thanks. Note that I'm not sure what -fno-vect-cost-model actually means when
> peeling for alignment, so this fix might not "prevail".
This broke the testcases -- you have to use dg-additional-options,
otherwise I now get
gcc.dg/vect/vect-44.c -flto -ffat-lto-objects : dump file does not exist
UNRESOLVED: gcc.dg/vect/vect-44.c -flto -ffat-lto-objects
scan-tree-dump-times vect "Alignment of access forced using peeling" 1
...
fixing that now.
Richard.
> Richard.
>
>> ChangeLog:
>> 2017-05-08 Wilco Dijkstra <wdijkstr@arm.com>
>>
>> * testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
>> * gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
>> --
>>
>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
>> index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
>> --- a/gcc/testsuite/gcc.dg/vect/vect-44.c
>> +++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
>> @@ -1,4 +1,5 @@
>> /* { dg-require-effective-target vect_float } */
>> +/* { dg-options "-fno-vect-cost-model" } */
>>
>> #include <stdarg.h>
>> #include "tree-vect.h"
>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
>> index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
>> --- a/gcc/testsuite/gcc.dg/vect/vect-50.c
>> +++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
>> @@ -1,4 +1,5 @@
>> /* { dg-require-effective-target vect_float } */
>> +/* { dg-options "-fno-vect-cost-model" } */
>>
>> #include <stdarg.h>
>> #include "tree-vect.h"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Testsuite, committed] Fix vector peeling test failures
2017-05-09 8:07 ` Richard Biener
@ 2017-05-09 8:13 ` Richard Biener
0 siblings, 0 replies; 4+ messages in thread
From: Richard Biener @ 2017-05-09 8:13 UTC (permalink / raw)
To: Wilco Dijkstra; +Cc: GCC Patches, nd, Christophe Lyon
On Tue, May 9, 2017 at 10:05 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Mon, May 8, 2017 at 3:49 PM, Richard Biener
> <richard.guenther@gmail.com> wrote:
>> On Mon, May 8, 2017 at 2:41 PM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
>>> This fixes a few failures on ARM and AArch64 due to a recent change in
>>> alignment peeling by switching the vector cost model off
>>> (https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00407.html).
>>>
>>> Tested on AArch64, ARM and x64 - committed as obvious.
>>
>> Thanks. Note that I'm not sure what -fno-vect-cost-model actually means when
>> peeling for alignment, so this fix might not "prevail".
>
> This broke the testcases -- you have to use dg-additional-options,
> otherwise I now get
>
> gcc.dg/vect/vect-44.c -flto -ffat-lto-objects : dump file does not exist
> UNRESOLVED: gcc.dg/vect/vect-44.c -flto -ffat-lto-objects
> scan-tree-dump-times vect "Alignment of access forced using peeling" 1
> ...
>
> fixing that now.
Oh, and -fno-vect-cost-model is the default anyway so your patch
couldn't have fixed anything.
Thus reverting instead.
Richard.
> Richard.
>
>> Richard.
>>
>>> ChangeLog:
>>> 2017-05-08 Wilco Dijkstra <wdijkstr@arm.com>
>>>
>>> * testsuite/gcc.dg/vect/vect-44.c: Add -fno-vect-cost-model.
>>> * gcc/testsuite/gcc.dg/vect/vect-50.c: Likewise.
>>> --
>>>
>>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-44.c b/gcc/testsuite/gcc.dg/vect/vect-44.c
>>> index 186f9cfc9e26d6eb53514dec0fac176d696ec578..fbc593572429422c8e527c5e5559c515efd38aa6 100644
>>> --- a/gcc/testsuite/gcc.dg/vect/vect-44.c
>>> +++ b/gcc/testsuite/gcc.dg/vect/vect-44.c
>>> @@ -1,4 +1,5 @@
>>> /* { dg-require-effective-target vect_float } */
>>> +/* { dg-options "-fno-vect-cost-model" } */
>>>
>>> #include <stdarg.h>
>>> #include "tree-vect.h"
>>> diff --git a/gcc/testsuite/gcc.dg/vect/vect-50.c b/gcc/testsuite/gcc.dg/vect/vect-50.c
>>> index 78bfd8d3920445fe51c7393a82870ea85f62bb55..0d5febc165ee3bf3b7b595237168d9d4b9604d4b 100644
>>> --- a/gcc/testsuite/gcc.dg/vect/vect-50.c
>>> +++ b/gcc/testsuite/gcc.dg/vect/vect-50.c
>>> @@ -1,4 +1,5 @@
>>> /* { dg-require-effective-target vect_float } */
>>> +/* { dg-options "-fno-vect-cost-model" } */
>>>
>>> #include <stdarg.h>
>>> #include "tree-vect.h"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-09 8:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 12:51 [Testsuite, committed] Fix vector peeling test failures Wilco Dijkstra
2017-05-08 14:31 ` Richard Biener via gcc-patches
2017-05-09 8:07 ` Richard Biener
2017-05-09 8:13 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).