From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by sourceware.org (Postfix) with ESMTPS id D33373858CDA; Mon, 22 Apr 2024 19:10:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D33373858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D33373858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713813032; cv=none; b=wQEzo0rrE+AIS0E3Y0fc96IkAeIDAI2M4wNKlUcBKhNU6CJbsVSuI7e0NxsIU0L3JGWLHUbpq/wVflhAi6RBTayZ2rRdpJVogZHziW84Br2L/UgdcVld/a43JmDFYfLityDLrZQHJRWQHuf6fcb3Agd+nmCzeFfae1lySa6Y66U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713813032; c=relaxed/simple; bh=RA2/aZuFQbR6ss9YuRqQ68opHDPhDgFkflv3z2qxm6Q=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=dZNf1rFvZKXRsz2GxD3o6yTYDqhHElKrM5GNTPF/W6QJYglUN8TdK6oJPDAmXn7QzcGcc+JgPHJwZ1EauuC3+AkWUpnRQ4IdV/pI9PYPVMAexHievY6wKaRDVsAP/fHmPGyX91X9rR1CentXCviVCUY65Ktz0rc74EJgVxJoIjg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2db2f6cb312so84138351fa.2; Mon, 22 Apr 2024 12:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713813028; x=1714417828; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LYgwnw8hu96h1/5vngxA+x8AkDTa/4LUB4uOPW2j4oY=; b=bizYY7jiM5tkIwlRFz/su3W++vFYjkMBevAGgjgigorunwHHYv3dR9wS1R4OBGG7fX ePC16fT9q+yshylbDZ8g6XArI9XkUaawTjbdOOIbeD87/U0P1+HnQe/zhmCqdy4h74BE mGkffqOczTftTxVva0FdX4rlFzmYwpM057FnGQcOkA+lXfpvoXPY9FPeSYNJeEo5SXC0 IQt4qOPOuF0xj8bYE/+tpahXW0EXKdkESTK4wIUto9f2Gl6FfPUp9EkdiJm1FDZNvpxj lBofCpLZrtVzGlePebTkOidLm6XlU4bvEifYlRSko187YJryUK05n/F+lie9DO/aKRrU wkJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713813028; x=1714417828; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LYgwnw8hu96h1/5vngxA+x8AkDTa/4LUB4uOPW2j4oY=; b=WJQMeL9mDYD8ELqgHueLREtMfJdambFpwna5T3Vfc+IiKRFk19VJ2duRlAi5Zduehi kKsMK4oxgFhDa2Rn5MwNttQlKUcJoeZSrTdEikZK9mNSgBqTRqooocL4ITCCEnkd4Bel Lm1YnCRcqtXIkiLArSHGXTzm9k7s/krsoiF/KFv8QJ9XcV5x7Sjhpqw5cfILAYKmgHAy /GHCkPpB4dPfhQ7aYT0YNt8vXNE8crr0fx+u2FRgxN0XOtWvTUNC4+PnIBT6iUlmfeiw VoEg6+0LHeEUe+IE2CcZtFbE8HOXYUNn6g05x1wOskpM+DnVTpKFwjzAEtUcavLnNLcI cAdA== X-Forwarded-Encrypted: i=1; AJvYcCX+Z1Jk3VDgVin2wRskn5fSMQZ6Zp9BNth9YcGOO1mOPQ1g5spmz4PwSnbcvgwCMREpr/l5hWl9U5sXeixd0BjDWg== X-Gm-Message-State: AOJu0Yzfm9Gfol+TclPKeQ7V8vsvht0I4xGV2QVt+nQAjFhWSFP9Gf0j j0JBfhbghU5OjpPN/UWKF7xldcwXjNN3gm/4hEj50gO+k+u/zHj2SvRtdDPMcXgfk95tzv9aDo7 l3Pexz02W8D4ntIn8oVCi8B45vUYIdPw1 X-Google-Smtp-Source: AGHT+IEcbx9wq9P4w52emiSWgbrN8IyJ9k/HFSeD4y5t37hreoGlsIc1UudPuNNH/ux+V/vIjlaOQogKmQgWMHedEyk= X-Received: by 2002:a19:6417:0:b0:51a:af26:f496 with SMTP id y23-20020a196417000000b0051aaf26f496mr8868898lfb.59.1713813027962; Mon, 22 Apr 2024 12:10:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 22 Apr 2024 21:10:16 +0200 Message-ID: Subject: Re: [PATCH] decay vect tests from run to link for pr95401 To: Alexandre Oliva Cc: GCC Patches , Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Apr 22, 2024 at 12:05=E2=80=AFPM Alexandre Oliva wrote: > > Ping?-ish for the full version of the RFC posted at > https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566588.html > > On Mar 11, 2021, Richard Biener wrote: > > > On Thu, Mar 11, 2021 at 9:03 AM Alexandre Oliva wro= te: > > >> So I'm leaning towards this proposed change, just extended to other > >> platforms that also decay from run to compile rather than link, and th= us > >> run into this problem in g++.dg/vect/pr95401.cc. Would this be > >> acceptable? > > > I think that's OK. It's probably difficult to make the test UNSUPPORTE= D > > when dg-additional-sources is discovered with a dg-do compile test? > > Thanks, here's a completed version. > > > When vect.exp finds our configuration disables altivec by default, it > disables the execution of vectorization tests, assuming the test > hardware doesn't support it. > > Tests become just compile tests, but compile tests won't work > correctly when additional sources are named, e.g. pr95401.cc, because > GCC refuses to compile multiple files into the same asm output. > > With this patch, the default for when execution is not possible > becomes link. > > Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with > gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? That makes sense. OK Thanks, Richard. > > for gcc/testsuite/ChangeLog > > * lib/target-supports.exp (check_vect_support_and_set_flags): > Decay to link rather than compile. > --- > gcc/testsuite/lib/target-supports.exp | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/ta= rget-supports.exp > index 3a5713d98691f..54a55585371b0 100644 > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > @@ -11625,7 +11625,7 @@ proc check_vect_support_and_set_flags { } { > if [check_750cl_hw_available] { > set dg-do-what-default run > } else { > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif [istarget powerpc*-*-*] { > # Skip targets not supporting -maltivec. > @@ -11655,14 +11655,14 @@ proc check_vect_support_and_set_flags { } { > # some other cpu type specified above. > set DEFAULT_VECTCFLAGS [linsert $DEFAULT_VECTCFLAGS 0 "-m= cpu=3D970"] > } > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif { [istarget i?86-*-*] || [istarget x86_64-*-*] } { > lappend DEFAULT_VECTCFLAGS "-msse2" > if { [check_effective_target_sse2_runtime] } { > set dg-do-what-default run > } else { > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif { [istarget mips*-*-*] > && [check_effective_target_nomips16] } { > @@ -11681,7 +11681,7 @@ proc check_vect_support_and_set_flags { } { > if [check_effective_target_ultrasparc_hw] { > set dg-do-what-default run > } else { > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif [istarget alpha*-*-*] { > # Alpha's vectorization capabilities are extremely limited. > @@ -11694,7 +11694,7 @@ proc check_vect_support_and_set_flags { } { > if [check_alpha_max_hw_available] { > set dg-do-what-default run > } else { > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif [istarget ia64-*-*] { > set dg-do-what-default run > @@ -11707,7 +11707,7 @@ proc check_vect_support_and_set_flags { } { > if [is-effective-target arm_neon_hw] { > set dg-do-what-default run > } else { > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif [istarget aarch64*-*-*] { > set dg-do-what-default run > @@ -11731,7 +11731,7 @@ proc check_vect_support_and_set_flags { } { > set dg-do-what-default run > } else { > lappend DEFAULT_VECTCFLAGS "-march=3Dz14" "-mzarch" > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif [istarget amdgcn-*-*] { > set dg-do-what-default run > @@ -11742,7 +11742,7 @@ proc check_vect_support_and_set_flags { } { > foreach item [add_options_for_riscv_v ""] { > lappend DEFAULT_VECTCFLAGS $item > } > - set dg-do-what-default compile > + set dg-do-what-default link > } > } elseif [istarget loongarch*-*-*] { > # Set the default vectorization option to "-mlsx" due to the probl= em > @@ -11751,7 +11751,7 @@ proc check_vect_support_and_set_flags { } { > if [check_effective_target_loongarch_sx_hw] { > set dg-do-what-default run > } else { > - set dg-do-what-default compile > + set dg-do-what-default link > } > } else { > return 0 > > > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > More tolerance and less prejudice are key for inclusion and diversity > Excluding neuro-others for not behaving ""normal"" is *not* inclusive