* Disable modref for ipa-pta-13.c testcase
@ 2020-09-25 11:04 Jan Hubicka
2020-09-25 11:19 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jan Hubicka @ 2020-09-25 11:04 UTC (permalink / raw)
To: gcc-patches, rguenther
Hi,
parameter tracking in ipa-modref causes failure of ipa-pta-13 testcase.
In partiuclar the check for "= x;" in fre3 is failing since we optimize
it out in fre1. As far as I can tell this is correct transform because
ipa-modref propagates the fact that the call is passed pointer to y.
Comment speaks of missed optimization, so I gues sit is OK to disable
modref here so we still test whatever this was testing before?
Honza
gcc/testsuite/ChangeLog:
2020-09-25 Jan Hubicka <hubicka@ucw.cz>
* gcc.dg/ipa/ipa-pta-13.c: Disable ipa-modref.
diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c b/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
index 93dd87107cc..e7bf6d485a4 100644
--- a/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
+++ b/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
@@ -1,5 +1,5 @@
/* { dg-do link } */
-/* { dg-options "-O2 -fipa-pta -fdump-ipa-pta2-details -fdump-tree-fre3 -fno-ipa-icf" } */
+/* { dg-options "-O2 -fipa-pta -fdump-ipa-pta2-details -fdump-tree-fre3 -fno-ipa-icf -fno-ipa-modref" } */
static int x, y;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Disable modref for ipa-pta-13.c testcase
2020-09-25 11:04 Disable modref for ipa-pta-13.c testcase Jan Hubicka
@ 2020-09-25 11:19 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2020-09-25 11:19 UTC (permalink / raw)
To: Jan Hubicka; +Cc: GCC Patches, Richard Guenther
On Fri, Sep 25, 2020 at 1:04 PM Jan Hubicka <hubicka@ucw.cz> wrote:
>
> Hi,
> parameter tracking in ipa-modref causes failure of ipa-pta-13 testcase.
> In partiuclar the check for "= x;" in fre3 is failing since we optimize
> it out in fre1. As far as I can tell this is correct transform because
> ipa-modref propagates the fact that the call is passed pointer to y.
> Comment speaks of missed optimization, so I gues sit is OK to disable
> modref here so we still test whatever this was testing before?
>
Hmm, I guess so. Ideally both local and local_address_taken would
be noipa but then IPA PTA wouldn't apply either ;) So yes, OK to
disable modref.
Richard.
> Honza
>
> gcc/testsuite/ChangeLog:
>
> 2020-09-25 Jan Hubicka <hubicka@ucw.cz>
>
> * gcc.dg/ipa/ipa-pta-13.c: Disable ipa-modref.
>
> diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c b/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
> index 93dd87107cc..e7bf6d485a4 100644
> --- a/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
> +++ b/gcc/testsuite/gcc.dg/ipa/ipa-pta-13.c
> @@ -1,5 +1,5 @@
> /* { dg-do link } */
> -/* { dg-options "-O2 -fipa-pta -fdump-ipa-pta2-details -fdump-tree-fre3 -fno-ipa-icf" } */
> +/* { dg-options "-O2 -fipa-pta -fdump-ipa-pta2-details -fdump-tree-fre3 -fno-ipa-icf -fno-ipa-modref" } */
>
> static int x, y;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-25 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 11:04 Disable modref for ipa-pta-13.c testcase Jan Hubicka
2020-09-25 11:19 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).