From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123292 invoked by alias); 5 Sep 2019 11:09:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 123278 invoked by uid 89); 5 Sep 2019 11:09:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=repair, H*f:sk:f93d3d6, H*i:sk:f93d3d6, otoh X-HELO: mail-lj1-f196.google.com Received: from mail-lj1-f196.google.com (HELO mail-lj1-f196.google.com) (209.85.208.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Sep 2019 11:09:51 +0000 Received: by mail-lj1-f196.google.com with SMTP id x18so2043593ljh.1; Thu, 05 Sep 2019 04:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kzxGlm7iYz9uSC03q4LoI2Z6m+4ur25jRJaAkl3Joaw=; b=bPTX3T7ka8Jk+9yIdWCNE1yQ+Ul71RlqTeU/lIUFQtF8nOauzyYsKQmaR4BUxnnlZQ vieNY8hV9SijdDXLYCxKsDrtwHfSfXnRsY1NEp6t6nevH5cicIFsGlSVpHNMcfdS8Em3 GZSQczbCmwWCGRNUsH3oloCmwLfJiJQK1Xaz6jx+CXDfwSbXsO/LxHltJJdpsRtp781P 7o7sbw5Z5LGQOllmBrhUDe4i+VoQIQoCF9ejT7ssS6hRxq6p7Jpmz11fvheKXM5+jLc6 uZ0n66LQnuu6nadup+76pqewR5DXW6nbQalpj0pKH1sHYFtiRbNcipBQ+eNxwnbYCKlx evLA== MIME-Version: 1.0 References: <69a11998-93c1-d61d-ba31-ac93bcbb353a@suse.cz> <20190621115838.GX815@tucnak> <79fcb5a4-0eba-d39f-e7ca-389f371cd48c@suse.cz> <20190621141309.GY815@tucnak> <140a1eb3-9652-9516-0274-19977fa3021d@suse.cz> <5c3aaf4a-b68a-f7a1-38b7-2e83182b0bc4@suse.cz> <91e9319a-6154-e252-35c2-cdcce679ea07@suse.cz> <82e53760-fae7-29a6-70b1-f601bac28bdc@suse.cz> In-Reply-To: From: Richard Biener Date: Thu, 05 Sep 2019 11:09:00 -0000 Message-ID: Subject: Re: [PATCH] Deprecate -frepo option. To: Nathan Sidwell Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , Jonathan Wakely , Jakub Jelinek , Iain Sandoe , "gcc@gcc.gnu.org" , David Edelsohn , Jan Hubicka , GCC Patches , Jason Merrill Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00269.txt.bz2 On Thu, Sep 5, 2019 at 1:02 PM Nathan Sidwell wrote: > > On 9/5/19 6:03 AM, Martin Li=C5=A1ka wrote: > > On 9/5/19 12:01 PM, Richard Biener wrote: > >> On Wed, Sep 4, 2019 at 2:57 PM Nathan Sidwell wrote: > >>> > >>> On 9/4/19 7:20 AM, Martin Li=C5=A1ka wrote: > >>>> On 9/4/19 11:22 AM, Jonathan Wakely wrote: > >>> > >>> > >>>>> The point of the warning was to see if users complain. Three weeks > >>>>> isn't a very long time to see if users are going to complain :-) > >>>>> > >>>> > >>>> I see :) That said, I'm going to install the patch close to the end > >>>> of stage1. > >>> > >>> I think it'd be ok to install it during stage3 (perhaps early feb?). > >>> More chance of people speaking up. > >> > >> I just checked and trunk doesn't spit out a warning for me so this > >> needs people to use 9.2+ to notice. > > > > Yep, it's intentional. Only GCC 9 branch prints the warning: > > > > $ gcc-9 -frepo main.cpp > > cc1plus: warning: =E2=80=98-frepo=E2=80=99 is deprecated and will be re= moved in a future release [-Wdeprecated] > > > > As we plan to remove it for trunk, it does not make sense to print the = warning for trunk. > > IMHO it very much makes sense for trunk to warn. > > old-gcc: deprecated > trunk: not deprectated > conclusion: it is no longer deprecated Once we remove -frepo it will be an option we simply ignore - correct? Then people won't notice it isn't used anymore (unless it fixes the build for them...). OTOH we figured -frepo is broken beyond repair so unless somebody steps up to actually _fix_ its issues I'm not sure what we should do when some people come around and say they use the option? So, let's just remove it now? Richard. > nathan > > -- > Nathan Sidwell