From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 74548385559B for ; Fri, 10 Nov 2023 14:20:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74548385559B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 74548385559B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699626044; cv=none; b=g1iUwgJLTo9vreSc0qV2tV3V+UYiv5waxauhYLnzCeAncyxgvKj1wtYiH7+dFh8EPEewJS8BxgCx4x7nPA07iEt7JZJihl1TNgswOagqeJ53cKzxwCJogqAQvS6Ot6NEvY14JTQMtVXk6f9TbTtUKBxO+TtRFdkF3LPVqXqXdY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699626044; c=relaxed/simple; bh=7KsTkTKGWEr/4CG7gyVYsaB71hrDXeDuIuSDiu3DUU4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=YMCVmsb9XNumrzkCxTidQ5iyAkVUdG5Pgznf0lIK5BBKfj6wJHdHyNx9b6sVydAeLflPMgUx9NolkK7ie526pQZ2mDA7KNjpjK2JSYo/DdsDE8qGtLpXyefMONXQt6en160udiQDKd/1maonO8w/S2suUT0do+rTlcVQVQ+sawA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5079f3f3d7aso2900402e87.1 for ; Fri, 10 Nov 2023 06:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699626042; x=1700230842; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PYZ9YNf4diu5BRLyD1iXzdYCTQJel1ZfHZWZoIXbZDA=; b=JGn2XUGPKdnc5s7qXIRCm0O7YV8co7wsXlmurnY4EXwUanFGHURMEjmuwt5K4zEi3o QWjG9Kj4K+t7AY+UX852f2wKoX1WU+QIk3+TP486D5sYeppX+o4ARJp4yCVv/1Bl4nJS PvZuX6CdbAMIeJXLKlRCuO0Y9VWg5MWnCPbxFeY/NxPMTTyCaOwIZfTt/sAK5HOCJejo 6WYLiuW90thfVjiw3xi6Iy+DOiU7B0+z7zOA59XVWQlgKwVU4mudt8IAdETUWaTbI0qj 1fZJc+WtqZ1yAppy8VY7ccVW+uN4c8qubgGnuwLHqtYvJ1eXlEHg40oOKkU8g53MWUe1 7qow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699626042; x=1700230842; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PYZ9YNf4diu5BRLyD1iXzdYCTQJel1ZfHZWZoIXbZDA=; b=DsYSCTqWCpn3JZV3QyJZqgXN/VD38NZ3+xyCjrO8TNPXeUcRqfcb17Wwz/QkVd69E0 h4A7D9TeI8zRqKpKA1wkW/zt6kRw0hHMoetSXqtNnZfif7be4dCAjPmPOeMQP9Qh7Saz lVTx/CYGPOGT8aOqN8YIm+SMzXjDvGT4RwSOMVSLS2BWPRLH6LV50kMBibCPeqF3W38/ TidI4YZGvCQSkCeIFOf54TDJHx1hfF1OlcWduunS3y9omsfh19unT+wrik7Q+SJ3TL/F Pk2zzJ5Wdf5E7NA35vTwc2v6vFx4acoKI0E5dC+9su3c2L3mKwqEY092RENStHRqf2XU QWyA== X-Gm-Message-State: AOJu0YxXry7CogcBZIEUoewYU/GElvgP9o8lwmT++LFZwBfPqo8w5gNf A3dTOEDFLYE9bQ3BklYdOgcbSI8JiTk9+ZovJYs= X-Google-Smtp-Source: AGHT+IEYIddouKopC4KwwR61KMsSoqVpbQAub9JQaQ/YVPDA9uSPy11sZMpbwl7PoWyQ0S8XL6ztXETwv2LieH0f6o4= X-Received: by 2002:a05:6512:2529:b0:509:7301:5738 with SMTP id be41-20020a056512252900b0050973015738mr5533931lfb.62.1699626041856; Fri, 10 Nov 2023 06:20:41 -0800 (PST) MIME-Version: 1.0 References: <85b4098e-a72f-d013-ff17-8097971f71ba@linux.ibm.com> <09FEFDAE-698B-4B06-A896-8088B9B31539@linaro.org> <4675c26c-f230-b6d6-27c5-bc9f74736e38@linux.ibm.com> <41a4d065-c4b6-4a67-adf0-e84e942616c7@gmail.com> <93ce3468-a1ee-e77c-cbeb-a8c67a303bf9@ispras.ru> In-Reply-To: From: Richard Biener Date: Fri, 10 Nov 2023 15:20:29 +0100 Message-ID: Subject: Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273] To: Alexander Monakov Cc: Jeff Law , "Kewen.Lin" , Maxim Kuvyrkov , GCC Patches , Richard Sandiford , Jeff Law , Vladimir Makarov , zhroma@ispras.ru, Andrey Belevantsev , Segher Boessenkool , Peter Bergner , Michael Meissner , Alexandre Oliva Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 10, 2023 at 3:18=E2=80=AFPM Alexander Monakov wrote: > > > On Fri, 10 Nov 2023, Richard Biener wrote: > > > > I'm afraid ignoring debug-only BBs goes contrary to overall var-track= ing design: > > > DEBUG_INSNs participate in dependency graph so that schedulers can re= move or > > > mutate them as needed when moving real insns across them. > > > > Note that debug-only BBs do not exist - the BB would be there even with= out debug > > insns! > > Yep, sorry, I misspoke when I earlier said > > >> and cause divergence when passing through a debug-only BB which would = not be > >> present at all without -g. > > They are present in the region, but skipped via no_real_insns_p. > > > So instead you have to handle BBs with just debug insns the same you > > handle a completely empty BB. > > Yeah. There would be no problem if the scheduler never used no_real_insns= _p > and handled empty and non-empty BBs the same way. And I suppose it would be OK to do that. Empty BBs are usually removed by CFG cleanup so the situation should only happen in rare corner cases where the fix would be to actually run CFG cleanup ... Richard. > Alexander