From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16605 invoked by alias); 18 Dec 2013 11:37:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16596 invoked by uid 89); 18 Dec 2013 11:37:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wg0-f47.google.com Received: from mail-wg0-f47.google.com (HELO mail-wg0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 Dec 2013 11:37:04 +0000 Received: by mail-wg0-f47.google.com with SMTP id n12so7204851wgh.2 for ; Wed, 18 Dec 2013 03:37:01 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.180.108.132 with SMTP id hk4mr7827305wib.12.1387366621193; Wed, 18 Dec 2013 03:37:01 -0800 (PST) Received: by 10.195.12.114 with HTTP; Wed, 18 Dec 2013 03:37:01 -0800 (PST) In-Reply-To: <52B04C0F.2040305@gjlay.de> References: <52A0937F.8020105@gjlay.de> <52B04C0F.2040305@gjlay.de> Date: Wed, 18 Dec 2013 11:37:00 -0000 Message-ID: Subject: Re: [Patch,avr]: Fix wrong warning PR59396 From: Richard Biener To: Georg-Johann Lay Cc: GCC Patches , Denis Chertykov Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg01565.txt.bz2 On Tue, Dec 17, 2013 at 2:05 PM, Georg-Johann Lay wrote: > Am 12/05/2013 04:09 PM, schrieb Richard Biener: >> >> On Thu, Dec 5, 2013 at 3:53 PM, Georg-Johann Lay wrote: >> >>> This is a fix of a wrong warning for a bas ISR name. The assumption was >>> that if DECL_ASSEMBLER_NAME is set, it would always starts with a *. >>> >>> This is not the case for LTO compiler where the assembler name is the >>> plain >>> name of the function (except an assembler name is set). >> >> >> That sounds odd to me. Does the bug reproduce with -fwhole-program? >> Or if the interrupt handler is static? > > > Hi, I tried to debug lto1. > > What I see is that SET_DECL_ASSEMBLER_NAME with "__vector_14", i.e. without > a leading '*', is called from > > tree-streamer-in.c:lto_input_ts_decl_with_vis_tree_pointers(). > > Hope that helps in narrowing down the issue. You need to debug the LTO IL creating process (cc1) then - this code merely restores what the compile-stage assigned the assembler name to. See tree.c:assign_assembler_name_if_needed. Richard. > Johann > > >> Richard. >> >>> Thus, do a more restrictive test if the first character of the function >>> name >>> has to be skipped. >>> >>> Ok to commit? >>> >>> Johann >>> >>> PR target/59396 >>> * config/avr/avr.c (avr_set_current_function): If the first char >>> of the function name is skipped, make sure it is actually '*'. > >