From: Richard Biener <richard.guenther@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: "Dominique d'Humières" <dominiq@lps.ens.fr>,
gfortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Move some array packing to front end
Date: Thu, 24 Jan 2019 11:01:00 -0000 [thread overview]
Message-ID: <CAFiYyc0pCM41NOTqWh0utSd72XywnDAc=WKZmhdN5XYPv3rT1Q@mail.gmail.com> (raw)
In-Reply-To: <950eca8c-519a-0110-0219-3f9615b0141e@netcologne.de>
On Wed, Jan 23, 2019 at 6:18 PM Thomas Koenig <tkoenig@netcologne.de> wrote:
>
> Hi Dominique,
>
> > FAIL: gfortran.dg/internal_pack_4.f90 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions execution test
> >
> > with -m32.
> >
> > gfc /opt/gcc/work/gcc/testsuite/gfortran.dg/internal_pack_4.f90 -O3 -funroll-loops -ftracer -m32
> >
> > is enough to trigger the miscomputation.
>
> Thanks, I will look into it.
>
> > The changes in the test suite are quite messy and I hope I did not miss any test (you should do "diff -N …" for the new tests).
>
> I don't think this is a good idea. Applying the patch twice will then
> double the test case.
>
>
> > Do you have test showing a speed-up?
>
> It' in the PR.
>
>
> > I agree with Richard that this patch should be held until the next stage 1.
>
> I just realized that we are, in principle, in regression-only mode.
>
> I do wish the announcements were also made to the fortran mailing lists.
They are made to the low-traffic gcc@ list which everybody working on GCC
is supposed to subscribe to.
> Anyway, I'll see if I can fix that bug, then attach the combined
> patch to the PR for later inclusion.
>
> Regards
>
> Thomas
next prev parent reply other threads:[~2019-01-24 10:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:22 Dominique d'Humières
2019-01-23 17:27 ` Thomas Koenig
2019-01-24 11:01 ` Richard Biener [this message]
2019-02-07 6:31 ` Chris Elrod
2019-01-23 21:41 ` Thomas Koenig
-- strict thread matches above, loose matches on Subject: below --
2019-01-22 21:10 Thomas Koenig
2019-01-23 8:22 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0pCM41NOTqWh0utSd72XywnDAc=WKZmhdN5XYPv3rT1Q@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dominiq@lps.ens.fr \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).