From: Richard Biener <richard.guenther@gmail.com>
To: Rich Felker <dalias@libc.org>, Jan Hubicka <hubicka@ucw.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] proposed fix for bug # 61144
Date: Wed, 21 May 2014 09:17:00 -0000 [thread overview]
Message-ID: <CAFiYyc0qj1Yc+VDchBYqsocT4aoyL01CMEB2LmzV3-=TcnHmBg@mail.gmail.com> (raw)
In-Reply-To: <20140521015948.GA21600@brightrain.aerifal.cx>
On Wed, May 21, 2014 at 3:59 AM, Rich Felker <dalias@libc.org> wrote:
> Bug # 61144 is a regression in 4.9.0 that breaks building of musl libc
> due to aggressive and semantically-incorrect constant folding of weak
> aliases. The attached patch seems to fix the issue. A weak alias
> should never be a candidate for constant folding because it may always
> be replaced by a strong definition from another translation unit.
>
> For details see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61144
>
> I do not have a copyright assignment on file but this patch should be
> sufficiently trivial not to require it.
Please add a testcase. Also I wonder why it isn't better to generalize
/* Variables declared 'const' without an initializer
have zero as the initializer if they may not be
overridden at link or run time. */
if (!DECL_INITIAL (real_decl)
&& (DECL_EXTERNAL (decl) || decl_replaceable_p (decl)))
return error_mark_node;
Honza?
Thanks,
Richard.
> Rich
next prev parent reply other threads:[~2014-05-21 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 1:59 Rich Felker
2014-05-21 9:17 ` Richard Biener [this message]
2014-05-22 3:59 ` Rich Felker
2014-05-23 18:26 ` Jeff Law
2014-06-06 17:14 ` Rich Felker
2014-06-09 11:41 ` Alexander Monakov
2014-06-09 18:46 ` Rich Felker
2014-06-16 9:06 ` Jan Hubicka
2014-06-16 13:38 ` Rich Felker
2014-06-16 16:05 ` Jan Hubicka
2014-06-16 16:35 ` Rich Felker
2014-06-14 21:24 ` Rich Felker
2014-06-16 8:56 ` Jan Hubicka
2014-07-22 17:18 ` Alexander Monakov
2014-07-22 17:23 ` Alexander Monakov
2014-07-22 17:30 ` Rich Felker
2014-07-23 9:06 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0qj1Yc+VDchBYqsocT4aoyL01CMEB2LmzV3-=TcnHmBg@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=dalias@libc.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).