From: Richard Biener <richard.guenther@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [debug-early] reuse variable DIEs and fix their context
Date: Thu, 28 Aug 2014 13:58:00 -0000 [thread overview]
Message-ID: <CAFiYyc0rftZkObJxo13UCwLvkhqMPNXkE11g-8tvdefQmhN2BQ@mail.gmail.com> (raw)
In-Reply-To: <53FD45A7.4000804@redhat.com>
On Wed, Aug 27, 2014 at 4:42 AM, Aldy Hernandez <aldyh@redhat.com> wrote:
> This patch fixes a bunch of guality failures. With it I get 144 guality.exp
> failures vs. 163 for "make check-gcc RUNTESTFLAGS=guality.exp". A lot
> better than 100% fail rate ;-).
>
> Variable DIEs were not being reused. Instead, variable DIEs even had the
> wrong context (unilaterally the compilation unit). The attached patch
> reuses variable DIEs that have been outputted earlier. It also fixes the
> context by correcting the context on the second round.
>
> I have also added a bit field to the DIE structure to record if a DIE has
> been generated early.
>
> Again, this is all a rough draft, but feel free to comment.
I wonder if we can't not force a proper context die (ISTR dwarf2out.c
lazily handles some contexts in some circumstances). All parent
"trees" should be readily available and we should be able to create
DIEs for them.
Richard.
> Committed to branch.
> Aldy
next prev parent reply other threads:[~2014-08-28 13:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 2:43 Aldy Hernandez
2014-08-28 13:58 ` Richard Biener [this message]
2014-08-28 17:35 ` Aldy Hernandez
2014-08-28 18:01 ` Jason Merrill
2014-08-28 19:13 ` Richard Biener
2014-08-28 20:14 ` Jason Merrill
2014-08-29 9:09 ` Richard Biener
2014-09-03 17:55 ` Aldy Hernandez
2014-09-04 10:42 ` Richard Biener
2014-09-05 2:38 ` Aldy Hernandez
2014-09-05 9:00 ` Richard Biener
2014-09-09 0:01 ` Aldy Hernandez
2014-09-09 9:16 ` Richard Biener
2014-09-12 0:51 ` Aldy Hernandez
2014-09-12 8:13 ` Richard Biener
2014-09-12 15:15 ` Jason Merrill
2014-09-12 17:11 ` Aldy Hernandez
2014-09-12 17:33 ` Jason Merrill
2014-09-12 17:48 ` Aldy Hernandez
2014-09-12 17:56 ` Jason Merrill
2014-09-16 15:49 ` Aldy Hernandez
2014-09-15 9:32 ` Richard Biener
2014-09-15 18:46 ` Jason Merrill
2014-12-18 19:26 ` Aldy Hernandez
2014-12-19 11:20 ` Richard Biener
2014-12-19 18:58 ` Jan Hubicka
2014-12-19 19:01 ` Jan Hubicka
2014-12-19 19:02 ` Aldy Hernandez
2014-12-19 19:31 ` Jason Merrill
2014-12-19 19:50 ` Jan Hubicka
2014-12-20 10:09 ` Aldy Hernandez
2015-01-08 12:24 ` Richard Biener
2014-12-19 19:03 ` Aldy Hernandez
2014-09-04 17:53 ` H.J. Lu
2014-09-04 17:54 ` Aldy Hernandez
2014-09-04 18:23 ` Richard Biener
2014-09-04 18:35 ` Aldy Hernandez
2014-09-04 18:38 ` Christophe Lyon
2014-09-04 19:42 ` Jan-Benedict Glaw
2015-01-08 15:20 Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc0rftZkObJxo13UCwLvkhqMPNXkE11g-8tvdefQmhN2BQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).