From: Richard Biener <richard.guenther@gmail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@caviumnetworks.com>
Cc: "marc.glisse@inria.fr" <marc.glisse@inria.fr>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)
Date: Thu, 23 Jul 2015 13:36:00 -0000 [thread overview]
Message-ID: <CAFiYyc0t3O6fuRsST=PHVBM5+cG1ata+2r=B2b47WN=pMjyfqg@mail.gmail.com> (raw)
In-Reply-To: <SN2PR0701MB1024E2FD81BA317E4CFFE98F8E820@SN2PR0701MB1024.namprd07.prod.outlook.com>
On Thu, Jul 23, 2015 at 5:47 AM, Hurugalawadi, Naveen
<Naveen.Hurugalawadi@caviumnetworks.com> wrote:
>>> so using wi::mask is prefered here.
>
> Thanks for your review and comments.
>
> Please find attached the modified patch as per your comments.
>
> Please let me know if this version is okay?
Ok with adding
/* { dg-require-effective-target int32 } */
to the testcase.
Please omit the
+/* Simplify (t * 2)/2 -> t. */
+(simplify
+ (exact_div (mult @0 INTEGER_CST@1) @1)
+ (if (TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (@0)))
+ @0))
pattern. As a followup extend it - it shoudl also work for non-INTEGER_CST
divisors and it should work for any kind of division, not just exact_div. The
key here is TYPE_OVERFLOW_UNDEFINED. I believe you should
find the equivalent operation in extract_trunc_div_1.
Richard.
> Thanks,
> Naveen
>
> 2015-07-22 Naveen H.S <Naveen.Hurugalawadi@caviumnetworks.com>
>
> gcc/testsuite/ChangeLog:
> PR middle-end/25529
> * gcc.dg/pr25529.c: New test.
>
> gcc/ChangeLog:
> PR middle-end/25529
> * match.pd (exact_div (mult @0 INTEGER_CST@1) @1) : New simplifier.
> (trunc_div (mult @0 integer_pow2p@1) @1) : New simplifier.
next prev parent reply other threads:[~2015-07-23 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 4:52 Hurugalawadi, Naveen
2015-07-07 6:06 ` Marc Glisse
2015-07-07 9:12 ` Richard Biener
2015-07-07 9:24 ` Marc Glisse
2015-07-07 9:35 ` Richard Biener
2015-07-21 9:16 ` Hurugalawadi, Naveen
2015-07-22 12:10 ` Richard Biener
2015-07-23 3:59 ` Hurugalawadi, Naveen
2015-07-23 13:36 ` Richard Biener [this message]
2015-08-07 8:44 ` Hurugalawadi, Naveen
2015-08-11 12:50 ` Richard Biener
2015-08-11 12:51 ` Richard Biener
2015-08-20 20:10 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc0t3O6fuRsST=PHVBM5+cG1ata+2r=B2b47WN=pMjyfqg@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=Naveen.Hurugalawadi@caviumnetworks.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).