From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56913 invoked by alias); 1 Jun 2015 12:18:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56898 invoked by uid 89); 1 Jun 2015 12:18:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f181.google.com Received: from mail-ob0-f181.google.com (HELO mail-ob0-f181.google.com) (209.85.214.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 01 Jun 2015 12:18:52 +0000 Received: by obcnx10 with SMTP id nx10so96169880obc.2 for ; Mon, 01 Jun 2015 05:18:50 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.62.105 with SMTP id x9mr17825461oer.1.1433161130394; Mon, 01 Jun 2015 05:18:50 -0700 (PDT) Received: by 10.76.115.167 with HTTP; Mon, 1 Jun 2015 05:18:50 -0700 (PDT) In-Reply-To: <556C444B.4040907@suse.cz> References: <555604F0.40802@suse.cz> <55688F1E.4070704@arm.com> <556C444B.4040907@suse.cz> Date: Mon, 01 Jun 2015 12:18:00 -0000 Message-ID: Subject: Re: [PATCH, RFC] New memory usage statistics infrastructure From: Richard Biener To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Vidya Praveen , GCC Patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00062.txt.bz2 On Mon, Jun 1, 2015 at 1:38 PM, Martin Li=C5=A1ka wrote: > On 05/29/2015 06:09 PM, Vidya Praveen wrote: >> >> Martin, >> >> The following change: >> >> @@ -2655,10 +2655,10 @@ s-iov: build/gcov-iov$(build_exeext) $(BASEVER) = $(DEVPHASE) >> >> GCOV_OBJS =3D gcov.o >> gcov$(exeext): $(GCOV_OBJS) $(LIBDEPS) >> - +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) $(LIBS) -o= $@ >> + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) build/hash= -table.o ggc-none.o $(LIBS) -o $@ >> >> >> seem to cause canadian cross build failure for arm and aarch64 on x86_64= as >> build/hash-table.o and ggc-none.o are not built by the same compiler? >> >> arm-none-linux-gnueabi-g++ -no-pie -g -O2 -DIN_GCC -fno-exceptions = -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing >> +-Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-vir= tual -pedantic -Wno-long-long -Wn >> build/hash-table.o ggc-none.o libcommon.a ../libcpp/libc= pp.a ../libbacktrace/.libs/libbacktrace.a ../libiberty/libiberty.a .. >> +/libdecnumber/libdecnumber.a -o gcov >> build/hash-table.o: file not recognized: File format not recognized >> collect2: error: ld returned 1 exit status >> make[1]: *** [gcov] Error 1 >> >> >> Should it be: >> >> - +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) $(LIBS) -o= $@ >> + +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) $(GCOV_OBJS) hash-table= .o ggc-none.o $(LIBS) -o $@ >> >> instead? > > Hello Vidya. > > Thanks for pointing out. To be honest, I'm not a build system guru and it= 's hard for me to verify > that the change you suggest is the correct. > > May I please ask you for sending a patch to mailing? gcov isn't a build but a host tool so the patch looks good to me. Richard. > Thanks, > Martin > >> >> VP. >> >> >> On 15/05/15 15:38, Martin Li=C5=A1ka wrote: >>> Hello. >>> >>> Following patch attempts to rewrite memory reports for GCC's internal a= llocations >>> so that it uses a new template type. The type shares parts which are cu= rrently duplicated, >>> adds support for special 'counters' and introduces new support for hash= -{set,map,table}. >>> >>> Transformation of the current code is a bit tricky as we internally use= d hash-table as main >>> data structure which takes care of location-related allocations. As I w= ant to add support even >>> for hash tables (and all derived types), header files inclusion and for= ward declaration is utilized. >>> >>> Feel free to comment the patch, as well as missing features one may wan= t to track by location sensitive >>> memory allocation. >>> >>> Attachment contains sample output taken from tramp3d-v4.cpp. >>> >>> Thanks, >>> Martin >>> >> >