From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 839E9385840A for ; Wed, 28 Jun 2023 07:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 839E9385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b699a2fe86so58343471fa.3 for ; Wed, 28 Jun 2023 00:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687936848; x=1690528848; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JfQ/q0wcIi4BKr/SmhYsVsxAJBDBVTzGhOk8g3tm0R8=; b=dZb4Sw6KVUNOrQFFm30Y/wcMudkDl16yT9XiwUeTHnjEyd2DsNluo1X0w5dTj87b1Z 105fchZDXfih4MvAsX5GL2k0XmeuZ3hfZUynWOEyJjJEEm7pw2dKKe70WOCwhW8NQ93x g3hD4N4ApI7o4+k3FylQsGl7DPr0JBYYbon3D4Vf8TJHjBjoVH1DBasJDK5fsMvB92IJ z7KFsH0BQvGQ4VmGWnPpNbCk8CLIjeqkYZ0mPZi4emqiMblqnwjKt78yRvmkCJ+Pv95T bGph4mgATAJ7CR6VAkj+WQQuOOAw7bMUJJxrV2kyDCGQS/FUG8/N9UvlQgNTRaW+0aPH qjng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687936848; x=1690528848; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JfQ/q0wcIi4BKr/SmhYsVsxAJBDBVTzGhOk8g3tm0R8=; b=iwVafAhpjCWWyptsFy0D9DbhFXHwsFTW5HRnUb6LNPMdJfduN0ZfZR7uLo121ewP9r s2MXgFyYuqesfOdV7T9biDiFwZMBcFSRsiLtw9MMD62xUqoscWS1WbvLy/6Ci0quT3q8 95MPSi/YVBVMaZ3WgjaM3lzfk7SCsDUAkqNzMd/UeLyoUi2k4DfkoU4TZJ2qA9mBoEsX +/Xt7mboOfTJVN9O8Emu4FGegKoXy+gvKBC7B6Q046pF2nL0MS8oeuTGjBbb59FhGUkX fJcHksnk/7qqJpI1vBnWAfJJxeUyjg37rUcaPYBVuM++HWvBkXtF8LZKIYptigs2hCjv VG8w== X-Gm-Message-State: AC+VfDziqoVvPv7QprQ38yWT0XKibOKApAqiPQFe8b5hgG1eW6GPqXvN 8EpTR3CplBtHHaSzHiTBfKprKgm88aaYuX3zn1U= X-Google-Smtp-Source: ACHHUZ7kZSJOXVybw/Wk5raz/CtHV9SK9TMRCAAPWiVgxQ/J9iW6NGE98VkNRjScVy/mkMLOC5M7Vzz2wiEURwVNPDI= X-Received: by 2002:a2e:b710:0:b0:2b6:adc4:aa2d with SMTP id j16-20020a2eb710000000b002b6adc4aa2dmr3694696ljo.18.1687936847537; Wed, 28 Jun 2023 00:20:47 -0700 (PDT) MIME-Version: 1.0 References: <20230628015944.112659-1-juzhe.zhong@rivai.ai> <5cd0b044-1816-302c-c563-d503d76c8f0b@gmail.com> In-Reply-To: <5cd0b044-1816-302c-c563-d503d76c8f0b@gmail.com> From: Richard Biener Date: Wed, 28 Jun 2023 09:17:39 +0200 Message-ID: Subject: Re: [PATCH V2] RISC-V: Fix bug of pre-calculated const vector mask To: Jeff Law Cc: Kito Cheng , "juzhe.zhong@rivai.ai" , gcc-patches , "kito.cheng" , palmer , palmer , Robin Dapp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 28, 2023 at 6:09=E2=80=AFAM Jeff Law via Gcc-patches wrote: > > > > On 6/27/23 21:16, Kito Cheng wrote: > > Do you mind giving some comments about what the difference between the > > two versions? > And I'd like a before/after assembly code with the example in the commit > message. I didn't see the same behavior when I tried it earlier today > and ran out of time to dig into it further. > > Juzhe -- most folks wait ~1wk to ping patches, even codegen bugfixes. > Pinging this fast runs the risk of irritating others. Please be patient. I think if we get constant mask expansion wrong this has to be fixed in generic code. ISTR fixing similar issues with AVX512 compact masks. But maybe I'm misunderstanding the problem and the issue only exists in the backend? Richard. > Jeff