From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3245 invoked by alias); 7 Mar 2013 09:55:19 -0000 Received: (qmail 3237 invoked by uid 22791); 7 Mar 2013 09:55:19 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wg0-f47.google.com (HELO mail-wg0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Mar 2013 09:55:14 +0000 Received: by mail-wg0-f47.google.com with SMTP id dr13so386911wgb.2 for ; Thu, 07 Mar 2013 01:55:13 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.181.13.175 with SMTP id ez15mr31618497wid.8.1362650112963; Thu, 07 Mar 2013 01:55:12 -0800 (PST) Received: by 10.194.56.100 with HTTP; Thu, 7 Mar 2013 01:55:12 -0800 (PST) In-Reply-To: References: Date: Thu, 07 Mar 2013 09:55:00 -0000 Message-ID: Subject: Re: [patch] minor bitmap.c GATHER_STATISTICS fix-ups From: Richard Biener To: Steven Bosscher Cc: GCC Patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00285.txt.bz2 On Thu, Mar 7, 2013 at 12:04 AM, Steven Bosscher wrote: > Hello, > > This patch fixes a bunch of smaller issues with GATHER_STATISTICS for > bitmaps: overflows in counters and ugly output format. > > Bootstrapped (with and without GATHER_STATISTICS) and regtested on > powerpc64-unknown-linux-gnu and on x86_64-unknown-linux-gnu. OK for > trunk? Ok. Thanks, Richard. > Ciao! > Steven > > > * bitmap.c (struct bitmap_descriptor_d): Use unsigned HOST_WIDEST_INT > for all counters. > (struct output_info): Likewise. > (register_overhead): Remove bad gcc_assert. > (bitmap_find_bit): If there is only a single bitmap element, do not > count a miss as a search. > (print_statistics): Update for counter type changes. > (dump_bitmap_statistics): Likewise. Print headers such that they > are properly lined up with the printed counters.